-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Enable corepack in CI #53152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable corepack in CI #53152
Conversation
The fact that we need a separate package manager to manage package managers is crazy; let's see how long until that space also gets fragmented and then we need a package manager manager manager... |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to try. Why do we need this?
This insulates us from the version of npm provided by the version of node that's installed, instead using the version of npm declared in package.json. Really, this only matters for anything that intends to actually modify Arguably, this should also be applied to the AzDo task we use to release TS to npm (non-nightly), as that's exactly what has broken us in the past; it using npm 6 which has different behavior that we use everywhere else. |
I opted to remove all but the ones where it matters. |
In lieu of actions/setup-node#531, enable this by hand.
I'm pretty sure this works. If it doesn't, everything will fail and that'll tell me everything I need.