Skip to content

Enable corepack in CI #53152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Enable corepack in CI #53152

merged 5 commits into from
Mar 14, 2023

Conversation

jakebailey
Copy link
Member

In lieu of actions/setup-node#531, enable this by hand.

I'm pretty sure this works. If it doesn't, everything will fail and that'll tell me everything I need.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 7, 2023
@fatcerberus
Copy link

The fact that we need a separate package manager to manage package managers is crazy; let's see how long until that space also gets fragmented and then we need a package manager manager manager...

@jakebailey
Copy link
Member Author

The fact that we need a separate package manager to manage package managers is crazy; let's see how long until that space also gets fragmented and then we need a package manager manager manager...

volta, pacman, .... 😄

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to try. Why do we need this?

@jakebailey
Copy link
Member Author

This insulates us from the version of npm provided by the version of node that's installed, instead using the version of npm declared in package.json. Really, this only matters for anything that intends to actually modify package.json or package-lock.json, so could be scoped down to just affect the update scripts, version bumpers, the release, etc, if desired, but if it were available on the setup-node action, I'd be enabling it everywhere.

Arguably, this should also be applied to the AzDo task we use to release TS to npm (non-nightly), as that's exactly what has broken us in the past; it using npm 6 which has different behavior that we use everywhere else.

@jakebailey
Copy link
Member Author

I opted to remove all but the ones where it matters.

@jakebailey jakebailey merged commit e08a2db into microsoft:main Mar 14, 2023
@jakebailey jakebailey deleted the corepack-ci branch March 14, 2023 16:59
@jakebailey jakebailey mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants