Skip to content

Make deeplyNestedTemplateLiteralIntersection run a little faster #53401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Mar 20, 2023

While it always passes on my machine, this apparently times out in CI sometimes; this was already a test case that was intended to take "a while" but not "too long", for perf measuring.

This PR just makes the test a little simpler to try and not hit the limit so bad.

The error message is not critical to the test, so it's fine to disappear.

For #52345

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 20, 2023
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark this test case pre-this-change as one for the hypothetical microbenchmark suite. :P

@jakebailey jakebailey merged commit b168b24 into microsoft:main Mar 21, 2023
@jakebailey jakebailey deleted the smaller-test-52345 branch March 21, 2023 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants