-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Tweak module resolution failed lookup watching #53420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
67389cf
to
4782611
Compare
…ive of allowJs files
4782611
to
3891ebf
Compare
…eself instead of its directory So with this before we use to ignore c:/typescript/node_modules watch as we will never watch c:/typescript now it will
3891ebf
to
b6bddbf
Compare
Co-authored-by: Daniel Rosenwasser <[email protected]>
PolledWatches:: | ||
/node_modules/@types: *new* | ||
{"pollingInterval":500} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why these were missing before and are added now? I don’t quite see why from the implementation change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i thought this was also handled by "canWatchFileOrDirectory" thing but we had logic for watching node_modules/@types
at tsconfig or jsconfig directory as well which has some issues when it is /
. I will look more into this and fix any other issues with config at root directory.
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at f64f2ad. You can monitor the build here. |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build and an npm module you can use via |
Closing this in favor of #53591 which i am still working on |
This simplifies unnecessary extension watching from long ago when we had different resolutions based on .ts and .js files
Before we would never watch directories like
c:/typescript/node_modules
or/user/username/typescript/node_modules
because we didnt watch folders likec:/typescript
or/user/username/typescript
. Now changed to watch node_modules in root folder. (We wont watch it at root unless tsconfig is at the root)This should help with some of the npm ci issues in repo encountered if typescript repo was at root or in another folder .