Fixed an issue with JSX children expression not being contextually discriminated

[Andarist]

fixes #53493

[jakebailey]

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster
@typescript-bot pack this

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 7f3335c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the extended test suite on this PR at 7f3335c. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the abridged perf test suite on this PR at 7f3335c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 7f3335c. You can monitor the build here.

[typescript-bot]

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 7f3335c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 7f3335c. You can monitor the build here.

Update: The results are in!

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/150999/artifacts?artifactName=tgz&fileId=E87CDBA779115C6F867ADD614D57E26BE95EEF03CD11E8385690B46BE735284A02&fileName=/typescript-5.1.0-insiders.20230325.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

[typescript-bot]

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53502/merge:

Everything looks good!

[typescript-bot]

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53502

Metric	main	53502	Delta	Best	Worst	p-value
Angular - node (v16.17.1, x64)
Memory used	361,603k (± 0.01%)	361,625k (± 0.00%)	~	361,612k	361,654k	p=0.173 n=6
Parse Time	3.52s (± 0.66%)	3.53s (± 0.83%)	~	3.50s	3.57s	p=0.809 n=6
Bind Time	1.18s (± 0.69%)	1.18s (± 0.54%)	~	1.17s	1.19s	p=0.432 n=6
Check Time	9.50s (± 0.50%)	9.48s (± 0.47%)	~	9.43s	9.55s	p=0.418 n=6
Emit Time	7.97s (± 0.52%)	7.92s (± 0.58%)	~	7.87s	7.99s	p=0.107 n=6
Total Time	22.17s (± 0.44%)	22.11s (± 0.34%)	~	22.01s	22.19s	p=0.196 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used	193,087k (± 0.68%)	192,511k (± 0.01%)	~	192,487k	192,536k	p=0.106 n=6
Parse Time	1.60s (± 0.32%)	1.58s (± 1.62%)	~	1.53s	1.60s	p=0.070 n=6
Bind Time	0.82s (± 1.09%)	0.82s (± 0.00%)	~	0.82s	0.82s	p=1.000 n=6
Check Time	10.32s (± 0.49%)	10.31s (± 0.62%)	~	10.24s	10.42s	p=0.574 n=6
Emit Time	2.99s (± 0.53%)	2.98s (± 0.46%)	~	2.97s	3.00s	p=0.564 n=6
Total Time	15.72s (± 0.42%)	15.69s (± 0.53%)	~	15.62s	15.84s	p=0.377 n=6
Monaco - node (v16.17.1, x64)
Memory used	345,742k (± 0.01%)	345,731k (± 0.00%)	~	345,713k	345,742k	p=0.336 n=6
Parse Time	2.70s (± 0.45%)	2.71s (± 0.69%)	~	2.70s	2.75s	p=0.451 n=6
Bind Time	1.08s (± 0.38%)	1.09s (± 0.50%)	~	1.08s	1.09s	p=0.054 n=6
Check Time	7.79s (± 0.31%)	7.80s (± 0.46%)	~	7.76s	7.84s	p=0.571 n=6
Emit Time	4.47s (± 0.61%)	4.46s (± 1.09%)	~	4.41s	4.54s	p=0.421 n=6
Total Time	16.04s (± 0.20%)	16.06s (± 0.53%)	~	15.98s	16.22s	p=1.000 n=6
TFS - node (v16.17.1, x64)
Memory used	300,004k (± 0.01%)	300,011k (± 0.01%)	~	299,970k	300,052k	p=0.748 n=6
Parse Time	2.16s (± 0.54%)	2.16s (± 0.70%)	~	2.15s	2.19s	p=0.804 n=6
Bind Time	1.23s (± 1.22%)	1.23s (± 1.11%)	~	1.22s	1.26s	p=1.000 n=6
Check Time	7.20s (± 0.35%)	7.18s (± 0.45%)	~	7.15s	7.24s	p=0.051 n=6
Emit Time	4.34s (± 0.84%)	4.33s (± 0.34%)	~	4.30s	4.34s	p=0.454 n=6
Total Time	14.94s (± 0.34%)	14.90s (± 0.43%)	~	14.86s	15.03s	p=0.196 n=6
material-ui - node (v16.17.1, x64)
Memory used	476,453k (± 0.00%)	476,453k (± 0.00%)	~	476,417k	476,470k	p=0.936 n=6
Parse Time	3.23s (± 0.36%)	3.22s (± 0.25%)	~	3.21s	3.23s	p=0.097 n=6
Bind Time	0.95s (± 0.43%)	0.95s (± 0.43%)	~	0.95s	0.96s	p=1.000 n=6
Check Time	18.13s (± 0.15%)	18.21s (± 0.40%)	~	18.13s	18.29s	p=0.052 n=6
Emit Time	0.00s (± 0.00%)	0.00s (± 0.00%)	~	0.00s	0.00s	p=1.000 n=6
Total Time	22.30s (± 0.17%)	22.38s (± 0.34%)	~	22.29s	22.46s	p=0.127 n=6
xstate - node (v16.17.1, x64)
Memory used	550,526k (± 0.02%)	550,526k (± 0.02%)	~	550,388k	550,715k	p=0.873 n=6
Parse Time	3.93s (± 0.21%)	3.94s (± 0.31%)	~	3.92s	3.95s	p=0.677 n=6
Bind Time	1.75s (± 0.72%)	1.75s (± 0.92%)	~	1.73s	1.77s	p=0.869 n=6
Check Time	3.07s (± 0.50%)	3.07s (± 0.54%)	~	3.05s	3.10s	p=0.803 n=6
Emit Time	0.09s (± 0.00%)	0.09s (± 0.00%)	~	0.09s	0.09s	p=1.000 n=6
Total Time	8.84s (± 0.18%)	8.85s (± 0.29%)	~	8.81s	8.88s	p=0.872 n=6

System

Machine Name	ts-ci-ubuntu
Platform	linux 5.4.0-135-generic
Architecture	x64
Available Memory	16 GB
Available Memory	15 GB
CPUs	4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz

Hosts

• node (v16.17.1, x64)

Scenarios

• Angular - node (v16.17.1, x64)
• Compiler-Unions - node (v16.17.1, x64)
• Monaco - node (v16.17.1, x64)
• TFS - node (v16.17.1, x64)
• material-ui - node (v16.17.1, x64)
• xstate - node (v16.17.1, x64)

Benchmark	Name	Iterations
Current	53502	6
Baseline	main	6

Developer Information:

Download Benchmark

[typescript-bot]

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

[typescript-bot]

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53502/merge:

Everything looks good!