Skip to content

Baseline some watch related path determinations so its easy to track changes #53598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 31, 2023

Conversation

sheetalkamat
Copy link
Member

No description provided.

@jakebailey
Copy link
Member

That 25K line file is 5 MB; is there a more compact representation that could be used?

@sheetalkamat
Copy link
Member Author

Tried to keep it readable but it helps i can split the tests further per osRoot?

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 31, 2023

Btw this should help me make saner changes so that i know i am doing right stuff or not.
Going to use for #53591

Eg look at https://github.com/microsoft/TypeScript/blob/f31529264ed6fbc40ae280e898a41651bcfdddeb/tests/baselines/reference/canWatch/canWatchAffectingLocation.baseline.md

@sheetalkamat sheetalkamat requested review from jakebailey and andrewbranch and removed request for jakebailey March 31, 2023 19:00
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the size; it turns out to matter over time since big blobs may not encode well (just like how just lib was inflating the checkout size by a lot).

@sheetalkamat
Copy link
Member Author

And i can reduce it further by removing white spaces but it doesnt read well in BC when comparing diffs so ...

@jakebailey
Copy link
Member

Ah, yeah, that would gain it all back. Would render identically in markdown anyhow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants