Properly handle partial union type properties in `isTypePresencePossible` #53794

ahejlsberg · 2023-04-15T21:23:11Z

ahejlsberg · 2023-04-16T14:05:17Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-04-16T14:05:21Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T14:05:21Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 119eb2a. You can monitor the build here.

typescript-bot · 2023-04-16T14:05:21Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T14:05:21Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T14:05:21Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 119eb2a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-04-16T14:17:26Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/53794/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Everything looks good!

typescript-bot · 2023-04-16T14:20:39Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53794

_Metric	_main	₅₃₇₉₄	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{364,557k (± 0.01%)}	_{364,553k (± 0.01%)}	_~	_364,516k	_364,572k	_{p=0.423 n=6}
_{Parse Time}	_{3.55s (± 0.37%)}	_{3.54s (± 0.42%)}	_~	_3.53s	_3.56s	_{p=0.458 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.18s (± 0.71%)}	_~	_1.17s	_1.19s	_{p=0.855 n=6}
_{Check Time}	_{9.51s (± 0.42%)}	_{9.51s (± 0.39%)}	_~	_9.46s	_9.57s	_{p=0.808 n=6}
_{Emit Time}	_{7.96s (± 1.35%)}	_{7.94s (± 0.40%)}	_~	_7.90s	_7.98s	_{p=0.809 n=6}
_{Total Time}	_{22.21s (± 0.53%)}	_{22.17s (± 0.23%)}	_~	_22.11s	_22.25s	_{p=0.936 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,574k (± 0.03%)}	_{192,555k (± 0.04%)}	_~	_192,465k	_192,691k	_{p=0.575 n=6}
_{Parse Time}	_{1.59s (± 0.32%)}	_{1.57s (± 1.74%)}	_~	_1.54s	_1.61s	_{p=0.199 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.82s (± 0.92%)}	_~	_0.81s	_0.83s	_{p=0.476 n=6}
_{Check Time}	_{10.19s (± 0.44%)}	_{10.21s (± 0.56%)}	_~	_10.15s	_10.30s	_{p=0.629 n=6}
_{Emit Time}	_{2.97s (± 0.66%)}	_{3.02s (± 1.52%)}	_~	_2.96s	_3.09s	_{p=0.052 n=6}
_{Total Time}	_{15.59s (± 0.31%)}	_{15.63s (± 0.32%)}	_~	_15.56s	_15.68s	_{p=0.260 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,754k (± 0.01%)}	_{345,749k (± 0.01%)}	_~	_345,717k	_345,795k	_{p=0.873 n=6}
_{Parse Time}	_{2.71s (± 0.30%)}	_{2.72s (± 0.30%)}	_~	_2.71s	_2.73s	_{p=0.666 n=6}
_{Bind Time}	_{1.08s (± 0.75%)}	_{1.09s (± 0.90%)}	_~	_1.08s	_1.11s	_{p=0.177 n=6}
_{Check Time}	_{7.83s (± 0.48%)}	_{7.84s (± 0.42%)}	_~	_7.79s	_7.89s	_{p=0.872 n=6}
_{Emit Time}	_{4.45s (± 0.93%)}	_{4.47s (± 1.55%)}	_~	_4.39s	_4.55s	_{p=0.871 n=6}
_{Total Time}	_{16.07s (± 0.49%)}	_{16.11s (± 0.54%)}	_~	_16.00s	_16.22s	_{p=0.521 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,031k (± 0.00%)}	_{300,066k (± 0.01%)}	_{+36k (+ 0.01%)}	_300,018k	_300,098k	_{p=0.045 n=6}
_{Parse Time}	_{2.15s (± 0.78%)}	_{2.15s (± 0.72%)}	_~	_2.14s	_2.18s	_{p=0.933 n=6}
_{Bind Time}	_{1.23s (± 0.33%)}	_{1.24s (± 0.79%)}	_~	_1.23s	_1.25s	_{p=0.056 n=6}
_{Check Time}	_{7.18s (± 0.26%)}	_{7.17s (± 0.32%)}	_~	_7.13s	_7.19s	_{p=0.505 n=6}
_{Emit Time}	_{4.35s (± 0.84%)}	_{4.33s (± 0.98%)}	_~	_4.26s	_4.37s	_{p=0.518 n=6}
_{Total Time}	_{14.90s (± 0.42%)}	_{14.88s (± 0.40%)}	_~	_14.78s	_14.94s	_{p=0.572 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,160k (± 0.01%)}	_{481,134k (± 0.01%)}	_~	_481,075k	_481,172k	_{p=0.471 n=6}
_{Parse Time}	_{3.24s (± 0.42%)}	_{3.25s (± 0.34%)}	_~	_3.23s	_3.26s	_{p=0.491 n=6}
_{Bind Time}	_{0.94s (± 0.88%)}	_{0.95s (± 0.43%)}	_~	_0.94s	_0.95s	_{p=0.285 n=6}
_{Check Time}	_{17.82s (± 0.65%)}	_{17.80s (± 0.46%)}	_~	_17.68s	_17.93s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.00s (± 0.55%)}	_{22.00s (± 0.36%)}	_~	_21.88s	_22.11s	_{p=0.936 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{559,385k (± 0.03%)}	_{559,338k (± 0.01%)}	_~	_559,281k	_559,427k	_{p=0.936 n=6}
_{Parse Time}	_{3.98s (± 0.27%)}	_{3.99s (± 0.52%)}	_~	_3.97s	_4.02s	_{p=0.157 n=6}
_{Bind Time}	_{1.75s (± 0.30%)}	_{1.75s (± 0.43%)}	_~	_1.74s	_1.76s	_{p=0.784 n=6}
_{Check Time}	_{3.02s (± 0.44%)}	_{3.01s (± 0.28%)}	_~	_3.00s	_3.02s	_{p=0.075 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.83s (± 0.19%)}	_{8.85s (± 0.17%)}	_~	_8.82s	_8.86s	_{p=0.138 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₇₉₄	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-04-16T16:08:06Z

Hey @ahejlsberg, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

typescript-bot · 2023-04-16T16:16:00Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/53794/merge:

Everything looks good!

ahejlsberg · 2023-04-16T23:18:45Z

Tests all clean and performance is unaffected. This is ready to merge.

ahejlsberg added 2 commits April 15, 2023 14:01

Properly handle partial union type properties isTypePresencePossible

6b3231b

Add regression tests

119eb2a

typescript-bot assigned ahejlsberg Apr 15, 2023

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Apr 15, 2023

ahejlsberg requested review from DanielRosenwasser, jakebailey and RyanCavanaugh April 16, 2023 23:19

jakebailey approved these changes Apr 17, 2023

View reviewed changes

DanielRosenwasser approved these changes Apr 17, 2023

View reviewed changes

DanielRosenwasser merged commit e782cef into main Apr 17, 2023

DanielRosenwasser deleted the fix53773 branch April 17, 2023 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Properly handle partial union type properties in `isTypePresencePossible` #53794

Properly handle partial union type properties in `isTypePresencePossible` #53794

Uh oh!

ahejlsberg commented Apr 15, 2023

Uh oh!

ahejlsberg commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Apr 16, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Apr 16, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Apr 16, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Apr 16, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

ahejlsberg commented Apr 16, 2023

Uh oh!

Uh oh!

Properly handle partial union type properties in isTypePresencePossible #53794

Properly handle partial union type properties in isTypePresencePossible #53794

Uh oh!

Conversation

ahejlsberg commented Apr 15, 2023

Uh oh!

ahejlsberg commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

typescript-bot commented Apr 16, 2023

Uh oh!

ahejlsberg commented Apr 16, 2023

Uh oh!

Uh oh!

Properly handle partial union type properties in `isTypePresencePossible` #53794

Properly handle partial union type properties in `isTypePresencePossible` #53794

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading

typescript-bot commented Apr 16, 2023 •

edited

Loading