Skip to content

Use custom conditions in path completions #54332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Use custom conditions in path completions #54332

merged 1 commit into from
Jun 1, 2023

Conversation

emmatown
Copy link
Contributor

Fixes #54331

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 20, 2023
@emmatown
Copy link
Contributor Author

@microsoft-github-policy-service agree

@sandersn sandersn requested a review from andrewbranch June 1, 2023 23:13
@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 1, 2023
@sandersn sandersn requested a review from iisaduan June 1, 2023 23:13
andrewbranch
andrewbranch approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrewbranch andrewbranch merged commit d49a285 into microsoft:main Jun 1, 2023
@emmatown emmatown deleted the use-custom-conditions-in-path-completions branch June 1, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@iisaduan iisaduan Awaiting requested review from iisaduan

Assignees

@andrewbranch andrewbranch

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customConditions isn't used in exports field path completions
3 participants
@emmatown @andrewbranch @typescript-bot