Optimize eagerly calculating `CouldContainTypeVariables` during object type instantiation #54538

weswigham · 2023-06-05T18:44:39Z

Basically, this conditionalizes the carrying-forward of type variable containment checks within getObjectTypeInstantiation more. The existing check pulls the flags forward onto primitives/unions/intersections which may result from instantiateMappedType unconditionally. This means we may mark unions and intersections as possibly containing type parameters when they in fact cannot.

Noticed this while rereviewing #53246 while reviewing #54507

within `getObjectTypeInstantiation` more. The existing check pulls the flags forward onto primitives/unions/intersections which may result from `instantiateMappedType` unconditionally. This means we may mark unions and intersections as possibly containing type parameters when they in fact cannot.

weswigham · 2023-06-05T18:44:52Z

@typescript-bot perf test this

typescript-bot · 2023-06-05T18:44:56Z

Heya @weswigham, I've started to run the perf test suite on this PR at 7698260. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T20:06:36Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..54538

_Metric	_main	₅₄₅₃₈	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,147k (± 0.00%)}	_{366,123k (± 0.01%)}	_{-24k (- 0.01%)}	_366,097k	_366,153k	_{p=0.030 n=6}
_{Parse Time}	_{3.44s (± 0.24%)}	_{3.43s (± 0.34%)}	_{-0.02s (- 0.44%)}	_3.42s	_3.45s	_{p=0.047 n=6}
_{Bind Time}	_{1.12s (± 0.56%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.091 n=6}
_{Check Time}	_{8.80s (± 0.49%)}	_{8.78s (± 0.67%)}	_~	_8.70s	_8.85s	_{p=0.630 n=6}
_{Emit Time}	_{7.50s (± 0.65%)}	_{7.45s (± 0.55%)}	_~	_7.40s	_7.51s	_{p=0.148 n=6}
_{Total Time}	_{20.86s (± 0.36%)}	_{20.78s (± 0.44%)}	_~	_20.68s	_20.88s	_{p=0.092 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,573k (± 1.27%)}	_{191,181k (± 0.02%)}	_~	_191,132k	_191,216k	_{p=0.748 n=6}
_{Parse Time}	_{1.52s (± 0.79%)}	_{1.49s (± 1.83%)}	_~	_1.46s	_1.53s	_{p=0.059 n=6}
_{Bind Time}	_{0.78s (± 0.66%)}	_{0.77s (± 1.27%)}	_~	_0.76s	_0.79s	_{p=0.191 n=6}
_{Check Time}	_{9.57s (± 0.70%)}	_{9.47s (± 0.11%)}	_{-0.09s (- 0.99%)}	_9.46s	_9.48s	_{p=0.004 n=6}
_{Emit Time}	_{2.75s (± 0.63%)}	_{2.77s (± 0.84%)}	_~	_2.74s	_2.80s	_{p=0.460 n=6}
_{Total Time}	_{14.62s (± 0.51%)}	_{14.50s (± 0.38%)}	_{-0.12s (- 0.80%)}	_14.43s	_14.56s	_{p=0.020 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,613k (± 0.01%)}	_{346,623k (± 0.01%)}	_~	_346,577k	_346,673k	_{p=0.688 n=6}
_{Parse Time}	_{2.61s (± 1.66%)}	_{2.60s (± 0.86%)}	_~	_2.58s	_2.63s	_{p=0.872 n=6}
_{Bind Time}	_{1.01s (± 0.75%)}	_{1.01s (± 1.25%)}	_~	_0.99s	_1.03s	_{p=0.788 n=6}
_{Check Time}	_{7.15s (± 0.27%)}	_{7.13s (± 0.66%)}	_~	_7.06s	_7.18s	_{p=0.375 n=6}
_{Emit Time}	_{4.25s (± 0.46%)}	_{4.24s (± 0.73%)}	_~	_4.21s	_4.28s	_{p=0.685 n=6}
_{Total Time}	_{15.01s (± 0.40%)}	_{14.98s (± 0.12%)}	_~	_14.96s	_15.01s	_{p=0.469 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,613k (± 0.01%)}	_{300,622k (± 0.00%)}	_~	_300,602k	_300,635k	_{p=0.261 n=6}
_{Parse Time}	_{2.06s (± 1.70%)}	_{2.08s (± 0.94%)}	_~	_2.06s	_2.11s	_{p=0.373 n=6}
_{Bind Time}	_{1.14s (± 0.96%)}	_{1.14s (± 1.29%)}	_~	_1.13s	_1.17s	_{p=1.000 n=6}
_{Check Time}	_{6.62s (± 0.53%)}	_{6.65s (± 1.52%)}	_~	_6.57s	_6.84s	_{p=0.872 n=6}
_{Emit Time}	_{3.89s (± 0.60%)}	_{3.89s (± 1.63%)}	_~	_3.82s	_4.01s	_{p=0.740 n=6}
_{Total Time}	_{13.71s (± 0.60%)}	_{13.77s (± 0.92%)}	_~	_13.65s	_13.97s	_{p=0.470 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{481,732k (± 0.01%)}	_{481,778k (± 0.01%)}	_~	_481,702k	_481,839k	_{p=0.092 n=6}
_{Parse Time}	_{3.13s (± 1.35%)}	_{3.12s (± 1.08%)}	_~	_3.08s	_3.16s	_{p=0.872 n=6}
_{Bind Time}	_{0.91s (± 1.28%)}	_{0.91s (± 0.89%)}	_~	_0.90s	_0.92s	_{p=0.738 n=6}
_{Check Time}	_{16.81s (± 0.79%)}	_{16.77s (± 0.27%)}	_~	_16.71s	_16.84s	_{p=0.873 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.85s (± 0.78%)}	_{20.81s (± 0.28%)}	_~	_20.75s	_20.92s	_{p=1.000 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,032k (± 0.03%)}	_{563,160k (± 0.03%)}	_~	_562,934k	_563,400k	_{p=0.230 n=6}
_{Parse Time}	_{3.85s (± 0.56%)}	_{3.84s (± 0.61%)}	_~	_3.80s	_3.87s	_{p=0.685 n=6}
_{Bind Time}	_{1.64s (± 0.60%)}	_{1.64s (± 0.92%)}	_~	_1.61s	_1.65s	_{p=0.934 n=6}
_{Check Time}	_{2.82s (± 1.26%)}	_{2.82s (± 0.41%)}	_~	_2.80s	_2.83s	_{p=1.000 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.38s (± 0.68%)}	_{8.38s (± 0.27%)}	_~	_8.35s	_8.40s	_{p=1.000 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,511k (± 0.01%)}	_{365,519k (± 0.01%)}	_~	_365,452k	_365,578k	_{p=0.810 n=6}
_{Parse Time}	_{3.58s (± 0.51%)}	_{3.57s (± 0.49%)}	_~	_3.56s	_3.60s	_{p=0.557 n=6}
_{Bind Time}	_{1.18s (± 0.54%)}	_{1.18s (± 0.44%)}	_~	_1.17s	_1.18s	_{p=0.386 n=6}
_{Check Time}	_{9.62s (± 0.24%)}	_{9.59s (± 0.51%)}	_~	_9.54s	_9.68s	_{p=0.198 n=6}
_{Emit Time}	_{7.96s (± 0.39%)}	_{7.91s (± 0.84%)}	_~	_7.84s	_8.03s	_{p=0.128 n=6}
_{Total Time}	_{22.34s (± 0.21%)}	_{22.25s (± 0.44%)}	_~	_22.15s	_22.44s	_{p=0.065 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,530k (± 0.70%)}	_{193,426k (± 0.67%)}	_~	_192,848k	_196,056k	_{p=0.173 n=6}
_{Parse Time}	_{1.61s (± 1.52%)}	_{1.61s (± 0.72%)}	_~	_1.60s	_1.63s	_{p=1.000 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.82s (± 0.63%)}	_~	_0.82s	_0.83s	_{p=0.112 n=6}
_{Check Time}	_{10.25s (± 0.74%)}	_{10.20s (± 0.59%)}	_~	_10.12s	_10.29s	_{p=0.261 n=6}
_{Emit Time}	_{3.01s (± 0.44%)}	_{3.00s (± 1.37%)}	_~	_2.97s	_3.07s	_{p=0.742 n=6}
_{Total Time}	_{15.70s (± 0.59%)}	_{15.63s (± 0.55%)}	_~	_15.51s	_15.74s	_{p=0.295 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,883k (± 0.01%)}	_{345,878k (± 0.00%)}	_~	_345,859k	_345,892k	_{p=1.000 n=6}
_{Parse Time}	_{2.73s (± 0.68%)}	_{2.72s (± 0.28%)}	_~	_2.71s	_2.73s	_{p=0.280 n=6}
_{Bind Time}	_{1.09s (± 0.37%)}	_{1.08s (± 0.50%)}	_~	_1.08s	_1.09s	_{p=0.282 n=6}
_{Check Time}	_{7.86s (± 0.45%)}	_{7.83s (± 0.39%)}	_~	_7.80s	_7.88s	_{p=0.225 n=6}
_{Emit Time}	_{4.46s (± 0.79%)}	_{4.46s (± 0.87%)}	_~	_4.41s	_4.52s	_{p=0.872 n=6}
_{Total Time}	_{16.14s (± 0.35%)}	_{16.10s (± 0.45%)}	_~	_16.04s	_16.21s	_{p=0.227 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,955k (± 0.01%)}	_{299,969k (± 0.01%)}	_~	_299,943k	_299,994k	_{p=0.378 n=6}
_{Parse Time}	_{2.16s (± 0.56%)}	_{2.18s (± 1.12%)}	_~	_2.15s	_2.21s	_{p=0.567 n=6}
_{Bind Time}	_{1.24s (± 0.68%)}	_{1.24s (± 0.83%)}	_~	_1.23s	_1.26s	_{p=0.149 n=6}
_{Check Time}	_{7.26s (± 0.50%)}	_{7.28s (± 0.42%)}	_~	_7.24s	_7.32s	_{p=0.871 n=6}
_{Emit Time}	_{4.33s (± 0.41%)}	_{4.33s (± 0.64%)}	_~	_4.29s	_4.36s	_{p=0.934 n=6}
_{Total Time}	_{15.00s (± 0.26%)}	_{15.03s (± 0.44%)}	_~	_14.94s	_15.13s	_{p=0.373 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,013k (± 0.01%)}	_{480,990k (± 0.00%)}	_~	_480,972k	_481,006k	_{p=0.261 n=6}
_{Parse Time}	_{3.28s (± 0.49%)}	_{3.27s (± 0.50%)}	_~	_3.25s	_3.29s	_{p=0.737 n=6}
_{Bind Time}	_{0.94s (± 0.43%)}	_{0.95s (± 1.09%)}	_~	_0.94s	_0.96s	_{p=0.461 n=6}
_{Check Time}	_{17.84s (± 0.37%)}	_{17.89s (± 1.02%)}	_~	_17.74s	_18.17s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.07s (± 0.33%)}	_{22.12s (± 0.85%)}	_~	_21.96s	_22.39s	_{p=0.748 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,613k (± 0.01%)}	_{560,613k (± 0.02%)}	_~	_560,466k	_560,770k	_{p=1.000 n=6}
_{Parse Time}	_{4.01s (± 0.58%)}	_{4.00s (± 0.72%)}	_~	_3.98s	_4.05s	_{p=0.629 n=6}
_{Bind Time}	_{1.77s (± 0.29%)}	_{1.77s (± 0.80%)}	_~	_1.75s	_1.79s	_{p=0.667 n=6}
_{Check Time}	_{3.05s (± 0.34%)}	_{3.06s (± 0.79%)}	_~	_3.03s	_3.09s	_{p=0.743 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.92s (± 0.33%)}	_{8.91s (± 0.36%)}	_~	_8.88s	_8.96s	_{p=0.573 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{359,508k (± 0.00%)}	_{359,547k (± 0.01%)}	_{+40k (+ 0.01%)}	_359,513k	_359,611k	_{p=0.031 n=6}
_{Parse Time}	_{3.70s (± 0.40%)}	_{3.67s (± 0.32%)}	_{-0.03s (- 0.81%)}	_3.66s	_3.69s	_{p=0.012 n=6}
_{Bind Time}	_{1.22s (± 0.33%)}	_{1.22s (± 0.67%)}	_~	_1.21s	_1.23s	_{p=0.584 n=6}
_{Check Time}	_{10.05s (± 0.49%)}	_{9.99s (± 0.55%)}	_~	_9.93s	_10.08s	_{p=0.126 n=6}
_{Emit Time}	_{8.37s (± 1.03%)}	_{8.29s (± 0.80%)}	_~	_8.23s	_8.38s	_{p=0.199 n=6}
_{Total Time}	_{23.33s (± 0.53%)}	_{23.17s (± 0.42%)}	_~	_23.06s	_23.33s	_{p=0.054 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,282k (± 0.01%)}	_{188,276k (± 0.01%)}	_~	_188,248k	_188,306k	_{p=0.630 n=6}
_{Parse Time}	_{1.62s (± 0.96%)}	_{1.62s (± 0.65%)}	_~	_1.60s	_1.63s	_{p=0.621 n=6}
_{Bind Time}	_{0.85s (± 0.00%)}	_{0.85s (± 0.89%)}	_~	_0.84s	_0.86s	_{p=0.598 n=6}
_{Check Time}	_{10.35s (± 0.31%)}	_{10.29s (± 0.43%)}	_{-0.06s (- 0.60%)}	_10.25s	_10.37s	_{p=0.045 n=6}
_{Emit Time}	_{3.15s (± 0.97%)}	_{3.12s (± 0.39%)}	_~	_3.10s	_3.13s	_{p=0.053 n=6}
_{Total Time}	_{15.97s (± 0.37%)}	_{15.87s (± 0.32%)}	_{-0.10s (- 0.65%)}	_15.83s	_15.97s	_{p=0.024 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,039k (± 0.00%)}	_{341,040k (± 0.00%)}	_~	_341,022k	_341,065k	_{p=0.936 n=6}
_{Parse Time}	_{2.83s (± 0.89%)}	_{2.80s (± 0.77%)}	_~	_2.78s	_2.84s	_{p=0.164 n=6}
_{Bind Time}	_{1.12s (± 0.75%)}	_{1.11s (± 0.46%)}	_~	_1.11s	_1.12s	_{p=0.923 n=6}
_{Check Time}	_{8.20s (± 0.26%)}	_{8.19s (± 0.54%)}	_~	_8.14s	_8.26s	_{p=0.570 n=6}
_{Emit Time}	_{4.68s (± 0.52%)}	_{4.70s (± 0.63%)}	_~	_4.67s	_4.75s	_{p=0.289 n=6}
_{Total Time}	_{16.82s (± 0.29%)}	_{16.81s (± 0.24%)}	_~	_16.74s	_16.86s	_{p=1.000 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,133k (± 0.00%)}	_{295,139k (± 0.00%)}	_~	_295,130k	_295,159k	_{p=0.810 n=6}
_{Parse Time}	_{2.42s (± 0.77%)}	_{2.42s (± 0.89%)}	_~	_2.39s	_2.45s	_{p=1.000 n=6}
_{Bind Time}	_{1.07s (± 0.84%)}	_{1.07s (± 0.70%)}	_~	_1.06s	_1.08s	_{p=0.798 n=6}
_{Check Time}	_{7.59s (± 0.46%)}	_{7.59s (± 0.47%)}	_~	_7.54s	_7.64s	_{p=1.000 n=6}
_{Emit Time}	_{4.35s (± 1.16%)}	_{4.33s (± 0.83%)}	_~	_4.28s	_4.38s	_{p=0.327 n=6}
_{Total Time}	_{15.43s (± 0.52%)}	_{15.41s (± 0.40%)}	_~	_15.30s	_15.48s	_{p=0.630 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{476,590k (± 0.00%)}	_{476,556k (± 0.01%)}	_{-34k (- 0.01%)}	_476,524k	_476,585k	_{p=0.020 n=6}
_{Parse Time}	_{3.36s (± 0.55%)}	_{3.35s (± 0.52%)}	_~	_3.33s	_3.38s	_{p=0.743 n=6}
_{Bind Time}	_{1.01s (± 0.40%)}	_{1.01s (± 0.40%)}	_~	_1.01s	_1.02s	_{p=1.000 n=6}
_{Check Time}	_{18.77s (± 0.73%)}	_{18.75s (± 0.57%)}	_~	_18.61s	_18.93s	_{p=0.575 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.14s (± 0.67%)}	_{23.12s (± 0.41%)}	_~	_23.00s	_23.27s	_{p=0.471 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{549,644k (± 0.00%)}	_{549,654k (± 0.00%)}	_~	_549,642k	_549,663k	_{p=0.109 n=6}
_{Parse Time}	_{4.24s (± 0.49%)}	_{4.27s (± 0.72%)}	_~	_4.22s	_4.30s	_{p=0.092 n=6}
_{Bind Time}	_{1.68s (± 0.48%)}	_{1.69s (± 0.87%)}	_~	_1.67s	_1.71s	_{p=0.677 n=6}
_{Check Time}	_{3.20s (± 0.79%)}	_{3.19s (± 0.61%)}	_~	_3.16s	_3.21s	_{p=0.466 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.22s (± 0.24%)}	_{9.24s (± 0.48%)}	_~	_9.16s	_9.28s	_{p=0.170 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₅₃₈	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..54538

_Metric	_main	₅₄₅₃₈	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,567ms (± 0.97%)}	_{2,553ms (± 0.53%)}	_~	_2,530ms	_2,566ms	_{p=0.423 n=6}
_{Req 2 - geterr}	_{5,535ms (± 1.56%)}	_{5,526ms (± 1.65%)}	_~	_5,349ms	_5,602ms	_{p=0.810 n=6}
_{Req 3 - references}	_{338ms (± 0.76%)}	_{338ms (± 0.67%)}	_~	_335ms	_341ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{287ms (± 0.57%)}	_{287ms (± 0.38%)}	_~	_286ms	_289ms	_{p=0.741 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 0.89%)}	_{85ms (± 1.05%)}	_~	_84ms	_86ms	_{p=0.149 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,656ms (± 0.85%)}	_{2,660ms (± 0.34%)}	_~	_2,649ms	_2,675ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{4,247ms (± 2.83%)}	_{4,312ms (± 0.49%)}	_~	_4,284ms	_4,347ms	_{p=0.936 n=6}
_{Req 3 - references}	_{349ms (± 1.31%)}	_{351ms (± 0.58%)}	_~	_349ms	_355ms	_{p=0.418 n=6}
_{Req 4 - navto}	_{292ms (± 0.73%)}	_{292ms (± 0.85%)}	_~	_289ms	_295ms	_{p=0.934 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{64ms (± 4.84%)}	_{64ms (± 4.31%)}	_~	_62ms	_69ms	_{p=0.452 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,101ms (± 0.55%)}	_{3,104ms (± 0.71%)}	_~	_3,070ms	_3,135ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{1,574ms (± 1.53%)}	_{1,575ms (± 1.28%)}	_~	_1,551ms	_1,597ms	_{p=1.000 n=6}
_{Req 3 - references}	_{113ms (± 2.19%)}	_{113ms (± 1.64%)}	_~	_111ms	_116ms	_{p=0.871 n=6}
_{Req 4 - navto}	_{361ms (± 0.72%)}	_{360ms (± 0.57%)}	_~	_357ms	_362ms	_{p=0.514 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,864 (± 0.00%)}	_~	_2,864	_2,864	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{378ms (± 3.36%)}	_{380ms (± 2.46%)}	_~	_366ms	_387ms	_{p=0.470 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,683ms (± 0.73%)}	_{2,688ms (± 1.20%)}	_~	_2,669ms	_2,753ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{6,059ms (± 0.45%)}	_{5,990ms (± 1.71%)}	_~	_5,789ms	_6,060ms	_{p=0.128 n=6}
_{Req 3 - references}	_{352ms (± 0.43%)}	_{352ms (± 0.51%)}	_~	_349ms	_354ms	_{p=0.869 n=6}
_{Req 4 - navto}	_{288ms (± 1.02%)}	_{289ms (± 1.65%)}	_~	_284ms	_295ms	_{p=0.625 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 5.77%)}	_{88ms (± 8.31%)}	_~	_74ms	_94ms	_{p=0.334 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,858ms (± 0.47%)}	_{2,839ms (± 0.43%)}	_{-19ms (- 0.66%)}	_2,819ms	_2,855ms	_{p=0.037 n=6}
_{Req 2 - geterr}	_{4,687ms (± 0.17%)}	_{4,683ms (± 0.41%)}	_~	_4,656ms	_4,710ms	_{p=0.629 n=6}
_{Req 3 - references}	_{364ms (± 0.58%)}	_{366ms (± 0.50%)}	_~	_364ms	_369ms	_{p=0.210 n=6}
_{Req 4 - navto}	_{289ms (± 0.86%)}	_{289ms (± 1.06%)}	_~	_285ms	_292ms	_{p=0.418 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{67ms (± 1.12%)}	_{67ms (± 1.12%)}	_~	_66ms	_68ms	_{p=1.000 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,229ms (± 0.69%)}	_{3,235ms (± 0.48%)}	_~	_3,215ms	_3,254ms	_{p=0.748 n=6}
_{Req 2 - geterr}	_{1,745ms (± 1.14%)}	_{1,747ms (± 1.13%)}	_~	_1,728ms	_1,779ms	_{p=0.809 n=6}
_{Req 3 - references}	_{126ms (± 7.24%)}	_{123ms (± 0.51%)}	_~	_122ms	_124ms	_{p=0.209 n=6}
_{Req 4 - navto}	_{344ms (± 0.89%)}	_{343ms (± 0.63%)}	_~	_340ms	_345ms	_{p=0.566 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,864 (± 0.00%)}	_~	_2,864	_2,864	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{415ms (± 1.88%)}	_{410ms (± 2.15%)}	_~	_402ms	_421ms	_{p=0.229 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,806ms (± 0.50%)}	_{2,799ms (± 0.42%)}	_~	_2,782ms	_2,816ms	_{p=0.295 n=6}
_{Req 2 - geterr}	_{6,196ms (± 0.45%)}	_{6,219ms (± 0.60%)}	_~	_6,182ms	_6,280ms	_{p=0.810 n=6}
_{Req 3 - references}	_{365ms (± 1.36%)}	_{362ms (± 0.62%)}	_~	_358ms	_364ms	_{p=0.163 n=6}
_{Req 4 - navto}	_{290ms (± 0.47%)}	_{288ms (± 0.52%)}	_~	_287ms	_290ms	_{p=0.215 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{101ms (± 4.19%)}	_{102ms (± 2.09%)}	_~	_99ms	_104ms	_{p=0.742 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,985ms (± 0.70%)}	_{2,984ms (± 0.75%)}	_~	_2,966ms	_3,022ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{4,575ms (± 0.35%)}	_{4,530ms (± 0.33%)}	_{-45ms (- 0.99%)}	_4,503ms	_4,545ms	_{p=0.005 n=6}
_{Req 3 - references}	_{376ms (± 0.22%)}	_{372ms (± 0.46%)}	_{-4ms (- 1.11%)}	_369ms	_374ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{299ms (± 0.44%)}	_{299ms (± 0.49%)}	_~	_296ms	_300ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 1.07%)}	_{76ms (± 0.54%)}	_~	_76ms	_77ms	_{p=0.584 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,488ms (± 0.49%)}	_{3,500ms (± 0.42%)}	_~	_3,481ms	_3,521ms	_{p=0.336 n=6}
_{Req 2 - geterr}	_{1,855ms (± 0.50%)}	_{1,838ms (± 0.53%)}	_{-17ms (- 0.89%)}	_1,829ms	_1,856ms	_{p=0.024 n=6}
_{Req 3 - references}	_{150ms (± 6.91%)}	_{149ms (± 9.28%)}	_~	_131ms	_161ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{406ms (± 1.41%)}	_{402ms (± 1.47%)}	_~	_397ms	_413ms	_{p=0.375 n=6}
_{Req 5 - completionInfo count}	_{2,864 (± 0.00%)}	_{2,864 (± 0.00%)}	_~	_2,864	_2,864	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{439ms (± 1.06%)}	_{434ms (± 2.58%)}	_~	_424ms	_450ms	_{p=0.298 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₅₃₈	₆
_Baseline	_main	₆

Startup

Comparison Report - main..54538

_Metric	_main	₅₄₅₃₈	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.03ms (± 0.23%)}	_{141.63ms (± 0.19%)}	_{-0.41ms (- 0.29%)}	_140.94ms	_146.23ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{221.91ms (± 0.32%)}	_{220.81ms (± 0.16%)}	_{-1.10ms (- 0.49%)}	_219.95ms	_224.96ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{224.43ms (± 0.37%)}	_{222.23ms (± 0.16%)}	_{-2.19ms (- 0.98%)}	_221.34ms	_229.51ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{204.39ms (± 0.19%)}	_{204.14ms (± 0.15%)}	_{-0.25ms (- 0.12%)}	_203.28ms	_207.66ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₄₅₃₈	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

weswigham · 2023-06-05T20:42:21Z

Yep no change to material-ui, but tiny gains in Compiler-Unions! 🙂

jakebailey

This looks good to me.

Should we backport this fix instead of #54507 to 5.1? Or does that feel too unsafe for a bugfix? (Mainly, are there actually performance regressions in 5.1 due to the previous optimization sometimes being too conservative?)

weswigham · 2023-06-05T22:28:30Z

@typescript-bot test this
@typescript-bot run dt
@typescript-bot test top100

Juuuust in case

typescript-bot · 2023-06-05T22:28:32Z

Heya @weswigham, I've started to run the diff-based top-repos suite on this PR at 7698260. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-05T22:28:32Z

Heya @weswigham, I've started to run the extended test suite on this PR at 7698260. You can monitor the build here.

typescript-bot · 2023-06-05T22:28:32Z

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 7698260. You can monitor the build here.

Update: The results are in!

weswigham · 2023-06-05T22:29:46Z

Mainly, are there actually performance regressions in 5.1 due to the previous optimization sometimes being too conservative?

Probably, but the effect is small, as you can see.

typescript-bot · 2023-06-05T22:42:50Z

Heya @weswigham, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-06-06T00:02:23Z

@weswigham Here are the results of running the top-repos suite comparing main and refs/pull/54538/merge:

Everything looks good!

typescript-bot · 2023-06-06T00:15:31Z

Hey @weswigham, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

Jolg42 · 2023-06-14T09:43:39Z

@weswigham @jakebailey I wanted to mention here that it could be beneficial to backport this to 5.1, see for more details the following issue #54549 (comment)

I'm trying to connect the dots, I hope this helps
Thanks for the good work 💚

typescript-bot assigned weswigham Jun 5, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 5, 2023

jakebailey mentioned this pull request Jun 5, 2023

Ensure we don't overwrite computed CouldContainTypeVariables in new optimization #54507

Merged

weswigham marked this pull request as ready for review June 5, 2023 20:41

weswigham requested review from ahejlsberg and jakebailey June 5, 2023 20:42

jakebailey approved these changes Jun 5, 2023

View reviewed changes

Merge branch 'main' into eager-type-variable-containment-optimization

a2dea3e

weswigham merged commit 3cfd6d2 into microsoft:main Jun 6, 2023

Jolg42 mentioned this pull request Jun 14, 2023

5.1.3 - RangeError: Maximum call stack size exceeded at inferFromTypes - Maybe Fixed with 5.2.0-dev.20230606 #54549

Closed

a-tarasyuk mentioned this pull request Jun 29, 2023

[WIP] fix(54655): Regression: bug in emitted declarations involving branded types since 5.1 #54833

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize eagerly calculating `CouldContainTypeVariables` during object type instantiation #54538

Optimize eagerly calculating `CouldContainTypeVariables` during object type instantiation #54538

weswigham commented Jun 5, 2023 •

edited

Loading

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023

Compiler

TSServer

Startup

weswigham commented Jun 5, 2023 •

edited

Loading

jakebailey left a comment

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 6, 2023

typescript-bot commented Jun 6, 2023

Jolg42 commented Jun 14, 2023

Optimize eagerly calculating CouldContainTypeVariables during object type instantiation #54538

Optimize eagerly calculating CouldContainTypeVariables during object type instantiation #54538

Conversation

weswigham commented Jun 5, 2023 • edited Loading

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 • edited Loading

typescript-bot commented Jun 5, 2023

Compiler

TSServer

Startup

weswigham commented Jun 5, 2023 • edited Loading

jakebailey left a comment

Choose a reason for hiding this comment

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023 • edited Loading

typescript-bot commented Jun 5, 2023 • edited Loading

typescript-bot commented Jun 5, 2023 • edited Loading

weswigham commented Jun 5, 2023

typescript-bot commented Jun 5, 2023

typescript-bot commented Jun 6, 2023

typescript-bot commented Jun 6, 2023

Jolg42 commented Jun 14, 2023

Optimize eagerly calculating `CouldContainTypeVariables` during object type instantiation #54538

Optimize eagerly calculating `CouldContainTypeVariables` during object type instantiation #54538

weswigham commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading

weswigham commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading

typescript-bot commented Jun 5, 2023 •

edited

Loading