Enable parsing of nested parameters for @callback JSDoc tag.
#54681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Jun 28, 2023
package-lock.json
Outdated
| @@ -45,7 +45,7 @@ | |||
| "fast-xml-parser": "^4.0.11", | |||
| "fs-extra": "^9.1.0", | |||
| "glob": "^8.1.0", | |||
| "hereby": "^1.6.4", | |||
| "hereby": "^1.8.1", | |||
There was a problem hiding this comment.
you probably shouldn't update hereby in this PR. Our overnight run regenerates package-lock.json to use the latest version.
There was a problem hiding this comment.
Thanks for noticing. I reverted them, downgraded them to the correct packages, and re-run hereby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36101
There was a conditional statement that prohibited parsing nested parameter types when the parent jsdoc tag is a
@callback. The check was there, because a structure to store nested param information was not defined.The structure has been added and the parser code was cleaned up. We only need to enable parsing nested parameters in code.
Attached is a test and updated baseline.
I am unfamiliar with
tsccodebase, so suggestions for additional tests are welcome!