Fix file matching with tsx and dts of same name are included by include patterns #55690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Sep 8, 2023
Member
|
@typescript-bot test top200 |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at f30084f. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at f30084f. You can monitor the build here. Update: The results are in! |
typescript-bot
added
For Milestone Bug
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Everything looks good! |
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Everything looks good! |
jakebailey
reviewed
Sep 11, 2023
Member
Author
|
Ping @weswigham @andrewbranch |
andrewbranch
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54389