Avoid unnecessary resolution-mode assertion in declaration emit

[andrewbranch]

Fixes the bug part of #55579, where the manual triple-slash reference workaround doesn’t work for @types/node.

When a type reference directive is processed, we also record what additional files the resolved types bring in via <reference path="..." /> directives. This way, when you reference a global declared in node_modules/@types/node/globals.d.ts, we can see that it actually came in via a <reference types="node" />. But instead of recording this entry with the resolution-mode that the types reference had, we recorded it with the resolution-mode that the file reference had, which is irrelevant (and could even lead to some totally incorrect results with some manufactured bizarre cases). All we need to know is how did this file enter the program? which is the type reference directive with whatever mode it had.

[andrewbranch]

@mpodwysocki I was never able to repro a case where the declaration emitter included a duplicate triple-slash directive, so I can’t be sure whether this fixes the whole problem. Would you mind trying this build out on your repro?

@typescript-bot pack this

[typescript-bot]

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 49f8c32. You can monitor the build here.

[typescript-bot]

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157676/artifacts?artifactName=tgz&fileId=7D92E271BFAD4CCDDEED93C285D7F869BF417D6FF114019F46959151848DB9CA02&fileName=/typescript-5.3.0-insiders.20230913.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

[mpodwysocki]

@mpodwysocki I was never able to repro a case where the declaration emitter included a duplicate triple-slash directive, so I can’t be sure whether this fixes the whole problem. Would you mind trying this build out on your repro?

@typescript-bot pack this

@andrewbranch it works perfectly, thank you!

[typescript-bot]

Heya @mpodwysocki, I've started to run the tarball bundle task on this PR at 49f8c32. You can monitor the build here.

[typescript-bot]

Hey @mpodwysocki, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/157693/artifacts?artifactName=tgz&fileId=49DD2CFB19567947EF8097C9BCC217E816045571BFEB8783F844333DC4DA70AB02&fileName=/typescript-5.3.0-insiders.20230913.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;