Use 'export * from' for public API instead of 'export =' #57163

jakebailey · 2024-01-25T05:39:13Z

In #57133, I noticed that the emit for export = is actually worse for our bundle by a good bit; if we use export * from, things are less nested and smaller. Nothing changes for the public API as far as I'm aware.

jakebailey · 2024-01-25T05:39:31Z

@typescript-bot perf test

typescript-bot · 2024-01-25T05:39:33Z

Heya @jakebailey, I've started to run the regular perf test suite on this PR at 5406f1d. You can monitor the build here.

Update: The results are in!

jakebailey · 2024-01-25T05:50:04Z

Ah, of course.

() => ts.version succeeded as expected.
() => ts.default.version failed as expected.
() => __importDefault(ts).version unexpectedly succeeded.
() => __importDefault(ts).default.version unexpectedly failed.
() => __importStar(ts).version succeeded as expected.
() => __importStar(ts).default.version unexpectedly failed.

In #51474 I actually did the reverse of this PR to fix #51473 and it's been long enough that I've forgotten.

I honestly don't understand this import helper stuff. I guess I could force __esModule back off again via another post-processing hack.

typescript-bot · 2024-01-25T06:21:10Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,643k (± 0.00%)}	_{295,658k (± 0.01%)}	_~	_295,627k	_295,701k	_{p=0.199 n=6}
_{Parse Time}	_{2.67s (± 0.52%)}	_{2.66s (± 0.39%)}	_~	_2.64s	_2.67s	_{p=0.183 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 1.25%)}	_~	_0.82s	_0.85s	_{p=0.090 n=6}
_{Check Time}	_{8.21s (± 0.25%)}	_{8.19s (± 0.17%)}	_~	_8.17s	_8.21s	_{p=0.102 n=6}
_{Emit Time}	_{7.09s (± 0.14%)}	_{7.08s (± 0.20%)}	_~	_7.06s	_7.10s	_{p=0.278 n=6}
_{Total Time}	_{18.79s (± 0.15%)}	_{18.76s (± 0.10%)}	_~	_18.74s	_18.79s	_{p=0.104 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{193,493k (± 1.57%)}	_{191,539k (± 0.01%)}	_~	_191,512k	_191,561k	_{p=1.000 n=6}
_{Parse Time}	_{1.36s (± 1.01%)}	_{1.36s (± 1.27%)}	_~	_1.34s	_1.39s	_{p=0.459 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.39%)}	_{9.33s (± 0.17%)}	_~	_9.31s	_9.35s	_{p=0.221 n=6}
_{Emit Time}	_{2.61s (± 0.46%)}	_{2.61s (± 0.46%)}	_~	_2.60s	_2.63s	_{p=0.406 n=6}
_{Total Time}	_{14.05s (± 0.30%)}	_{14.02s (± 0.15%)}	_~	_13.99s	_14.05s	_{p=0.170 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,445k (± 0.01%)}	_{347,452k (± 0.00%)}	_~	_347,425k	_347,475k	_{p=0.810 n=6}
_{Parse Time}	_{2.47s (± 0.40%)}	_{2.48s (± 0.59%)}	_~	_2.46s	_2.50s	_{p=0.117 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.92s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=0.311 n=6}
_{Check Time}	_{6.90s (± 0.41%)}	_{6.94s (± 0.48%)}	_~	_6.90s	_6.99s	_{p=0.089 n=6}
_{Emit Time}	_{4.05s (± 0.34%)}	_{4.06s (± 0.38%)}	_~	_4.03s	_4.07s	_{p=0.163 n=6}
_{Total Time}	_{14.34s (± 0.18%)}	_{14.40s (± 0.30%)}	_{+0.06s (+ 0.43%)}	_14.35s	_14.46s	_{p=0.016 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,832k (± 0.01%)}	_{302,831k (± 0.01%)}	_~	_302,806k	_302,861k	_{p=1.000 n=6}
_{Parse Time}	_{2.02s (± 0.75%)}	_{2.01s (± 0.70%)}	_~	_1.99s	_2.03s	_{p=0.683 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{1.01s (± 1.02%)}	_~	_1.00s	_1.02s	_{p=0.386 n=6}
_{Check Time}	_{6.32s (± 0.41%)}	_{6.32s (± 0.54%)}	_~	_6.28s	_6.38s	_{p=1.000 n=6}
_{Emit Time}	_{3.59s (± 0.50%)}	_{3.60s (± 0.23%)}	_~	_3.59s	_3.61s	_{p=0.405 n=6}
_{Total Time}	_{12.93s (± 0.25%)}	_{12.94s (± 0.25%)}	_~	_12.89s	_12.99s	_{p=0.567 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,292k (± 0.01%)}	_{511,288k (± 0.01%)}	_~	_511,245k	_511,321k	_{p=0.936 n=6}
_{Parse Time}	_{2.64s (± 0.57%)}	_{2.64s (± 0.77%)}	_~	_2.62s	_2.66s	_{p=0.802 n=6}
_{Bind Time}	_{1.00s (± 0.98%)}	_{0.99s (± 0.76%)}	_~	_0.98s	_1.00s	_{p=0.109 n=6}
_{Check Time}	_{17.16s (± 0.28%)}	_{17.21s (± 0.42%)}	_~	_17.12s	_17.30s	_{p=0.422 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.80s (± 0.32%)}	_{20.84s (± 0.40%)}	_~	_20.73s	_20.95s	_{p=0.375 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{1,694,559k (± 0.00%)}	_{1,694,543k (± 0.00%)}	_~	_1,694,505k	_1,694,590k	_{p=1.000 n=6}
_{Parse Time}	_{6.52s (± 0.43%)}	_{6.54s (± 0.69%)}	_~	_6.49s	_6.62s	_{p=0.936 n=6}
_{Bind Time}	_{2.36s (± 0.50%)}	_{2.36s (± 0.22%)}	_~	_2.35s	_2.36s	_{p=0.929 n=6}
_{Check Time}	_{55.20s (± 0.48%)}	_{54.99s (± 0.35%)}	_~	_54.78s	_55.30s	_{p=0.230 n=6}
_{Emit Time}	_{0.16s (± 0.00%)}	_{0.16s (± 0.00%)}	_~	_0.16s	_0.16s	_{p=1.000 n=6}
_{Total Time}	_{64.23s (± 0.44%)}	_{64.04s (± 0.27%)}	_~	_63.82s	_64.34s	_{p=0.230 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,413,515k (± 0.04%)}	_{2,413,530k (± 0.03%)}	_~	_2,412,631k	_2,414,561k	_{p=0.936 n=6}
_{Parse Time}	_{4.95s (± 1.00%)}	_{4.96s (± 0.68%)}	_~	_4.90s	_4.99s	_{p=0.809 n=6}
_{Bind Time}	_{1.88s (± 1.10%)}	_{1.87s (± 0.98%)}	_~	_1.85s	_1.89s	_{p=0.739 n=6}
_{Check Time}	_{33.42s (± 0.24%)}	_{33.49s (± 0.13%)}	_~	_33.44s	_33.56s	_{p=0.199 n=6}
_{Emit Time}	_{2.69s (± 0.95%)}	_{2.69s (± 2.31%)}	_~	_2.63s	_2.78s	_{p=0.810 n=6}
_{Total Time}	_{42.97s (± 0.21%)}	_{43.04s (± 0.13%)}	_~	_42.96s	_43.11s	_{p=0.173 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{419,725k (± 0.02%)}	_{419,723k (± 0.01%)}	_~	_419,694k	_419,747k	_{p=1.000 n=6}
_{Parse Time}	_{2.72s (± 3.21%)}	_{2.75s (± 2.86%)}	_~	_2.67s	_2.83s	_{p=0.515 n=6}
_{Bind Time}	_{1.17s (± 6.50%)}	_{1.14s (± 6.56%)}	_~	_1.07s	_1.21s	_{p=0.140 n=6}
_{Check Time}	_{15.10s (± 0.23%)}	_{15.12s (± 0.10%)}	_~	_15.10s	_15.14s	_{p=0.332 n=6}
_{Emit Time}	_{1.15s (± 1.19%)}	_{1.14s (± 0.72%)}	_~	_1.13s	_1.15s	_{p=0.181 n=6}
_{Total Time}	_{20.14s (± 0.21%)}	_{20.15s (± 0.13%)}	_~	_20.11s	_20.19s	_{p=0.227 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,808,372k (± 0.00%)}	_{2,808,376k (± 0.00%)}	_~	_2,808,322k	_2,808,461k	_{p=0.936 n=6}
_{Parse Time}	_{10.63s (± 0.59%)}	_{10.63s (± 0.31%)}	_~	_10.58s	_10.68s	_{p=0.936 n=6}
_{Bind Time}	_{3.39s (± 0.40%)}	_{3.39s (± 0.68%)}	_~	_3.36s	_3.42s	_{p=1.000 n=6}
_{Check Time}	_{59.69s (± 0.61%)}	_{59.56s (± 0.32%)}	_~	_59.36s	_59.83s	_{p=0.575 n=6}
_{Emit Time}	_{16.13s (± 0.29%)}	_{16.11s (± 0.53%)}	_~	_15.98s	_16.24s	_{p=0.628 n=6}
_{Total Time}	_{89.84s (± 0.41%)}	_{89.68s (± 0.27%)}	_~	_89.44s	_90.13s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{392,551k (± 0.01%)}	_{392,611k (± 0.01%)}	_{+60k (+ 0.02%)}	_392,553k	_392,676k	_{p=0.045 n=6}
_{Parse Time}	_{3.06s (± 0.72%)}	_{3.04s (± 0.68%)}	_~	_3.02s	_3.07s	_{p=0.324 n=6}
_{Bind Time}	_{1.39s (± 0.74%)}	_{1.39s (± 0.64%)}	_~	_1.38s	_1.40s	_{p=0.673 n=6}
_{Check Time}	_{13.96s (± 0.27%)}	_{13.98s (± 0.28%)}	_~	_13.91s	_14.02s	_{p=0.334 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.41s (± 0.23%)}	_{18.41s (± 0.18%)}	_~	_18.35s	_18.44s	_{p=0.803 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,390k (± 0.01%)}	_{513,412k (± 0.01%)}	_~	_513,361k	_513,492k	_{p=0.630 n=6}
_{Parse Time}	_{3.27s (± 0.32%)}	_{3.27s (± 0.36%)}	_~	_3.25s	_3.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.54s (± 0.33%)}	_{1.54s (± 0.26%)}	_~	_1.54s	_1.55s	_{p=0.595 n=6}
_{Check Time}	_{2.85s (± 0.72%)}	_{2.84s (± 0.39%)}	_~	_2.82s	_2.85s	_{p=0.290 n=6}
_{Emit Time}	_{0.08s (± 4.99%)}	_{0.08s (± 4.99%)}	_~	_0.08s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{7.75s (± 0.25%)}	_{7.73s (± 0.26%)}	_~	_7.72s	_7.76s	_{p=0.145 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,345ms (± 0.51%)}	_{2,350ms (± 0.69%)}	_~	_2,321ms	_2,366ms	_{p=0.520 n=6}
_{Req 2 - geterr}	_{5,498ms (± 1.79%)}	_{5,479ms (± 1.01%)}	_~	_5,432ms	_5,583ms	_{p=0.688 n=6}
_{Req 3 - references}	_{324ms (± 0.26%)}	_{323ms (± 0.54%)}	_~	_320ms	_324ms	_{p=0.474 n=6}
_{Req 4 - navto}	_{276ms (± 1.11%)}	_{277ms (± 1.01%)}	_~	_272ms	_279ms	_{p=0.869 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 8.48%)}	_{83ms (± 7.02%)}	_~	_79ms	_94ms	_{p=0.673 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,490ms (± 1.45%)}	_{2,490ms (± 0.98%)}	_~	_2,458ms	_2,512ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,223ms (± 1.91%)}	_{4,198ms (± 2.19%)}	_~	_4,110ms	_4,288ms	_{p=0.575 n=6}
_{Req 3 - references}	_{335ms (± 1.78%)}	_{339ms (± 1.81%)}	_~	_331ms	_346ms	_{p=0.416 n=6}
_{Req 4 - navto}	_{284ms (± 0.41%)}	_{285ms (± 1.05%)}	_~	_283ms	_291ms	_{p=0.402 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 6.39%)}	_{85ms (± 7.17%)}	_~	_77ms	_90ms	_{p=0.416 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,606ms (± 0.60%)}	_{2,597ms (± 0.47%)}	_~	_2,575ms	_2,607ms	_{p=0.109 n=6}
_{Req 2 - geterr}	_{1,723ms (± 2.41%)}	_{1,695ms (± 2.91%)}	_~	_1,654ms	_1,759ms	_{p=0.520 n=6}
_{Req 3 - references}	_{120ms (± 8.52%)}	_{120ms (± 8.85%)}	_~	_106ms	_129ms	_{p=0.738 n=6}
_{Req 4 - navto}	_{370ms (± 0.78%)}	_{370ms (± 0.20%)}	_~	_369ms	_371ms	_{p=0.672 n=6}
_{Req 5 - completionInfo count}	_{2,078 (± 0.00%)}	_{2,078 (± 0.00%)}	_~	_2,078	_2,078	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{310ms (± 1.23%)}	_{307ms (± 1.47%)}	_~	_301ms	_313ms	_{p=0.170 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.36ms (± 0.21%)}	_{153.17ms (± 0.17%)}	_{-0.19ms (- 0.12%)}	_152.21ms	_156.61ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.18ms (± 0.16%)}	_{227.98ms (± 0.15%)}	_{-0.21ms (- 0.09%)}	_226.60ms	_234.22ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.47ms (± 0.22%)}	_{227.39ms (± 0.16%)}	_{-3.07ms (- 1.33%)}	_225.92ms	_233.92ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.24ms (± 0.22%)}	_{225.78ms (± 0.57%)}	_{-3.46ms (- 1.51%)}	_224.35ms	_284.48ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-01-26T18:37:24Z

I stuck this into #57133.

Use 'export * from' for public API instead of 'export ='

5406f1d

typescript-bot assigned jakebailey Jan 25, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 25, 2024

jakebailey added 2 commits January 24, 2024 22:08

Use silly hack

600c25c

Fix lint

9fe52dc

jakebailey mentioned this pull request Jan 26, 2024

Fill out metafile export names in iife mode, or provide way to get exported names in non-ESM mode evanw/esbuild#3607

Open

jakebailey closed this Jan 26, 2024

jakebailey deleted the export-star-api branch March 15, 2024 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use 'export * from' for public API instead of 'export =' #57163

Use 'export * from' for public API instead of 'export =' #57163

jakebailey commented Jan 25, 2024

jakebailey commented Jan 25, 2024

typescript-bot commented Jan 25, 2024 •

edited

Loading

jakebailey commented Jan 25, 2024

typescript-bot commented Jan 25, 2024

tsc

tsserver

startup

jakebailey commented Jan 26, 2024

Use 'export * from' for public API instead of 'export =' #57163

Use 'export * from' for public API instead of 'export =' #57163

Conversation

jakebailey commented Jan 25, 2024

jakebailey commented Jan 25, 2024

typescript-bot commented Jan 25, 2024 • edited Loading

jakebailey commented Jan 25, 2024

typescript-bot commented Jan 25, 2024

tsc

tsserver

startup

jakebailey commented Jan 26, 2024

typescript-bot commented Jan 25, 2024 •

edited

Loading