Fix completion and quick info crash in type parameter in function in type alias #5781
Conversation
| // For example | ||
| // type list<T> = T[]; // Both T will go through same code path | ||
| let declaration = <TypeAliasDeclaration>getDeclarationOfKind(symbol, SyntaxKind.TypeParameter).parent; | ||
| displayParts.push(keywordPart(SyntaxKind.TypeKeyword)); | ||
| displayParts.push(spacePart()); | ||
| addFullSymbolName(declaration.symbol); |
There was a problem hiding this comment.
declaration may not be defined here with the new if clause
There was a problem hiding this comment.
that is a good point. I will have to come up with different test case when that can happen. My first intuition is that that case should not happen since when we get type parameter, it must be in a declaration. Regardless I will handle the behavior.
| if (signatureDeclaration.kind === SyntaxKind.ConstructSignature) { | ||
| displayParts.push(keywordPart(SyntaxKind.NewKeyword)); | ||
| displayParts.push(spacePart()); | ||
| let declaration = <Node>getDeclarationOfKind(symbol, SyntaxKind.TypeParameter); |
There was a problem hiding this comment.
When can declaration be undefined? Would it suffice to assert instead ?
There was a problem hiding this comment.
I agree that it probably should be assert instead. I will update it
mhegazy
changed the title
|
👍 |
|
@yuit the failing status on this PR was due to the issue in master - it's fixed now, however to update the status on your PR you'll need to refresh it. |
|
|
||
| if (declaration) { | ||
| if (isFunctionLikeKind(declaration.kind)) { | ||
| let signature = typeChecker.getSignatureFromDeclaration(<SignatureDeclaration>declaration); |
There was a problem hiding this comment.
This should probably be const
|
@weswigham Thanks for the head up! |
Fix completion and quick info crash in type parameter in function in type alias
Fix #4715 and #4616