Fixed crash on circular local type arguments when outer ones are present too #59089

Andarist · 2024-07-01T07:27:50Z

…ent too

andrewbranch · 2024-07-01T21:20:50Z

typescript-bot · 2024-07-01T21:20:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-01T21:42:15Z

Hey @andrewbranch, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-01T21:48:28Z

@andrewbranch Here are the results of running the user tests with tsc comparing main and refs/pull/59089/merge:

Everything looks good!

typescript-bot · 2024-07-01T21:56:18Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,258k (± 0.85%)}	_{193,405k (± 0.94%)}	_~	_192,108k	_195,736k	_{p=0.936 n=6}
_{Parse Time}	_{1.31s (± 0.31%)}	_{1.30s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=0.115 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.46s (± 0.30%)}	_{9.41s (± 0.46%)}	_~	_9.35s	_9.47s	_{p=0.078 n=6}
_{Emit Time}	_{2.75s (± 0.50%)}	_{2.76s (± 0.69%)}	_~	_2.73s	_2.78s	_{p=0.510 n=6}
_{Total Time}	_{14.23s (± 0.19%)}	_{14.18s (± 0.28%)}	_~	_14.15s	_14.25s	_{p=0.089 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,050	_407,050	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,369k (± 0.00%)}	_{1,218,368k (± 0.00%)}	_~	_1,218,311k	_1,218,399k	_{p=0.936 n=6}
_{Parse Time}	_{6.66s (± 0.89%)}	_{6.63s (± 0.40%)}	_~	_6.59s	_6.66s	_{p=0.228 n=6}
_{Bind Time}	_{1.87s (± 0.65%)}	_{1.86s (± 0.68%)}	_~	_1.85s	_1.88s	_{p=0.362 n=6}
_{Check Time}	_{30.63s (± 0.25%)}	_{30.55s (± 0.15%)}	_~	_30.49s	_30.61s	_{p=0.171 n=6}
_{Emit Time}	_{13.55s (± 0.31%)}	_{13.58s (± 0.18%)}	_~	_13.53s	_13.60s	_{p=0.169 n=6}
_{Total Time}	_{52.70s (± 0.17%)}	_{52.62s (± 0.13%)}	_~	_52.50s	_52.69s	_{p=0.228 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,136,980	_2,136,980	_~	_~	_~	_{p=1.000 n=6}
_Types	_929,117	_929,117	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,117,697k (± 0.00%)}	_{2,117,788k (± 0.00%)}	_~	_2,117,719k	_2,117,914k	_{p=0.066 n=6}
_{Parse Time}	_{6.63s (± 0.30%)}	_{6.63s (± 0.21%)}	_~	_6.61s	_6.65s	_{p=1.000 n=6}
_{Bind Time}	_{2.32s (± 0.59%)}	_{2.31s (± 0.45%)}	_~	_2.30s	_2.33s	_{p=0.680 n=6}
_{Check Time}	_{70.79s (± 0.41%)}	_{70.88s (± 0.53%)}	_~	_70.36s	_71.40s	_{p=0.748 n=6}
_{Emit Time}	_{0.14s (± 5.97%)}	_{0.14s (± 3.77%)}	_~	_0.13s	_0.14s	_{p=0.929 n=6}
_{Total Time}	_{79.87s (± 0.36%)}	_{79.96s (± 0.47%)}	_~	_79.47s	_80.50s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,262	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,340,954k (± 0.07%)}	_{2,340,239k (± 0.03%)}	_~	_2,338,924k	_2,340,811k	_{p=0.575 n=6}
_{Parse Time}	_{5.03s (± 1.01%)}	_{5.01s (± 0.79%)}	_~	_4.94s	_5.06s	_{p=0.470 n=6}
_{Bind Time}	_{1.90s (± 0.29%)}	_{1.93s (± 2.00%)}	_{+0.04s (+ 1.93%)}	_1.89s	_2.00s	_{p=0.032 n=6}
_{Check Time}	_{34.27s (± 0.61%)}	_{34.29s (± 0.20%)}	_~	_34.22s	_34.39s	_{p=1.000 n=6}
_{Emit Time}	_{2.60s (± 3.62%)}	_{2.64s (± 6.49%)}	_~	_2.48s	_2.90s	_{p=0.810 n=6}
_{Total Time}	_{43.82s (± 0.69%)}	_{43.87s (± 0.31%)}	_~	_43.68s	_44.03s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,225,260	_1,225,262	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,341	_261,341	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,414,882k (± 0.04%)}	_{2,414,399k (± 0.02%)}	_~	_2,413,304k	_2,415,075k	_{p=0.378 n=6}
_{Parse Time}	_{6.29s (± 0.84%)}	_{6.23s (± 0.50%)}	_~	_6.19s	_6.27s	_{p=0.066 n=6}
_{Bind Time}	_{2.02s (± 0.85%)}	_{2.02s (± 0.93%)}	_~	_1.99s	_2.04s	_{p=0.871 n=6}
_{Check Time}	_{40.81s (± 0.46%)}	_{40.83s (± 0.55%)}	_~	_40.61s	_41.17s	_{p=0.936 n=6}
_{Emit Time}	_{3.14s (± 2.77%)}	_{3.17s (± 2.94%)}	_~	_3.04s	_3.28s	_{p=0.573 n=6}
_{Total Time}	_{52.26s (± 0.55%)}	_{52.27s (± 0.62%)}	_~	_51.94s	_52.72s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,194	_258,196	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,737	_104,737	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,435k (± 0.01%)}	_{427,476k (± 0.01%)}	_~	_427,432k	_427,515k	_{p=0.066 n=6}
_{Parse Time}	_{4.10s (± 1.08%)}	_{4.08s (± 1.00%)}	_~	_4.03s	_4.15s	_{p=0.745 n=6}
_{Bind Time}	_{1.61s (± 1.34%)}	_{1.63s (± 1.42%)}	_~	_1.59s	_1.65s	_{p=0.370 n=6}
_{Check Time}	_{21.98s (± 0.27%)}	_{22.00s (± 0.62%)}	_~	_21.83s	_22.18s	_{p=0.936 n=6}
_{Emit Time}	_{1.55s (± 1.45%)}	_{1.55s (± 1.18%)}	_~	_1.52s	_1.57s	_{p=1.000 n=6}
_{Total Time}	_{29.25s (± 0.40%)}	_{29.26s (± 0.47%)}	_~	_29.12s	_29.46s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,497k (± 0.02%)}	_{369,556k (± 0.04%)}	_~	_369,365k	_369,779k	_{p=0.575 n=6}
_{Parse Time}	_{2.76s (± 1.14%)}	_{2.77s (± 1.47%)}	_~	_2.74s	_2.85s	_{p=0.687 n=6}
_{Bind Time}	_{1.58s (± 0.52%)}	_{1.58s (± 0.40%)}	_~	_1.57s	_1.59s	_{p=0.432 n=6}
_{Check Time}	_{15.48s (± 0.13%)}	_{15.48s (± 0.14%)}	_~	_15.46s	_15.52s	_{p=0.567 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.82s (± 0.24%)}	_{19.83s (± 0.30%)}	_~	_19.79s	_19.95s	_{p=0.687 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,879,975	_2,879,975	_~	_~	_~	_{p=1.000 n=6}
_Types	_975,327	_975,327	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,042,850k (± 0.00%)}	_{3,042,827k (± 0.00%)}	_~	_3,042,769k	_3,042,878k	_{p=0.378 n=6}
_{Parse Time}	_{13.68s (± 0.18%)}	_{13.73s (± 0.45%)}	_~	_13.67s	_13.82s	_{p=0.106 n=6}
_{Bind Time}	_{4.27s (± 2.82%)}	_{4.27s (± 2.82%)}	_~	_4.18s	_4.43s	_{p=0.685 n=6}
_{Check Time}	_{74.55s (± 1.62%)}	_{74.49s (± 2.15%)}	_~	_73.15s	_77.23s	_{p=0.873 n=6}
_{Emit Time}	_{23.15s (± 5.32%)}	_{23.31s (± 7.27%)}	_~	_20.52s	_24.49s	_{p=0.471 n=6}
_{Total Time}	_{115.64s (± 0.26%)}	_{115.79s (± 0.43%)}	_~	_115.31s	_116.47s	_{p=0.688 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,117	_267,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,775	_108,775	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,555k (± 0.02%)}	_{411,575k (± 0.01%)}	_~	_411,518k	_411,676k	_{p=0.423 n=6}
_{Parse Time}	_{4.69s (± 0.42%)}	_{4.69s (± 0.43%)}	_~	_4.67s	_4.73s	_{p=0.560 n=6}
_{Bind Time}	_{2.06s (± 0.73%)}	_{2.08s (± 0.68%)}	_~	_2.06s	_2.10s	_{p=0.097 n=6}
_{Check Time}	_{20.67s (± 0.39%)}	_{20.75s (± 0.51%)}	_~	_20.59s	_20.87s	_{p=0.230 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.43s (± 0.29%)}	_{27.53s (± 0.45%)}	_~	_27.35s	_27.70s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_525,251	_525,251	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,574	_178,574	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,894k (± 0.06%)}	_{462,799k (± 0.08%)}	_~	_462,349k	_463,160k	_{p=0.810 n=6}
_{Parse Time}	_{3.19s (± 0.38%)}	_{3.17s (± 0.93%)}	_~	_3.15s	_3.22s	_{p=0.224 n=6}
_{Bind Time}	_{1.17s (± 0.44%)}	_{1.17s (± 0.84%)}	_~	_1.15s	_1.18s	_{p=0.386 n=6}
_{Check Time}	_{17.90s (± 0.48%)}	_{17.96s (± 0.56%)}	_~	_17.84s	_18.11s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.27s (± 0.39%)}	_{22.31s (± 0.51%)}	_~	_22.16s	_22.44s	_{p=0.378 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-01T23:11:43Z

@andrewbranch Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59089/merge:

Everything looks good!

src/compiler/checker.ts

DanielRosenwasser · 2024-07-02T21:34:00Z

Approved, though I'd also like the nits from Jake fixed up.

Andarist · 2024-07-15T21:26:50Z

thanks @gabritto !

Fixed crash on circular local type arguments when outer ones are pres…

ca0295b

…ent too

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 1, 2024

andrewbranch approved these changes Jul 1, 2024

View reviewed changes

andrewbranch requested review from sandersn and gabritto July 1, 2024 23:14

jakebailey reviewed Jul 1, 2024

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

DanielRosenwasser approved these changes Jul 2, 2024

View reviewed changes

refactor

2298551

gabritto merged commit ec446b6 into microsoft:main Jul 15, 2024
29 checks passed

Andarist deleted the fix/circular-type-args-local-outer-crash branch July 15, 2024 22:01

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed crash on circular local type arguments when outer ones are present too #59089

Fixed crash on circular local type arguments when outer ones are present too #59089

Andarist commented Jul 1, 2024

andrewbranch commented Jul 1, 2024

typescript-bot commented Jul 1, 2024 •

edited

Loading

typescript-bot commented Jul 1, 2024

typescript-bot commented Jul 1, 2024

typescript-bot commented Jul 1, 2024

tsc

typescript-bot commented Jul 1, 2024

DanielRosenwasser commented Jul 2, 2024

Andarist commented Jul 15, 2024

Fixed crash on circular local type arguments when outer ones are present too #59089

Fixed crash on circular local type arguments when outer ones are present too #59089

Conversation

Andarist commented Jul 1, 2024

andrewbranch commented Jul 1, 2024

typescript-bot commented Jul 1, 2024 • edited Loading

typescript-bot commented Jul 1, 2024

typescript-bot commented Jul 1, 2024

typescript-bot commented Jul 1, 2024

tsc

typescript-bot commented Jul 1, 2024

DanielRosenwasser commented Jul 2, 2024

Andarist commented Jul 15, 2024

typescript-bot commented Jul 1, 2024 •

edited

Loading