Fix captured shorthand properties in ES2015 loops #59285

jakebailey · 2024-07-15T20:30:34Z

Two problems:

isInExpressionContext (and by extension isExpressionNode) didn't consider the case of "name only" object prop shorthand. This meant we weren't even walking into the shorthand in this example. ~~Fixing this caused knock-on effects in some baselines, but I'm not sure any are actually a problem.~~ They are ☹️

Then, we were using getSymbolAtLocation to get the node for the shorthand prop, but that ended up returning the wrong symbol; we want the one for the "value side" of the prop. Switching to getResolvedSymbol (same as the other caller of checkIdentifierCalculateNodeCheckFlags) seems to fix that.

Not 100% certain if this makes perf bad, though. I assume not given we already had to call the same symbol stuff via getSymbolAtLocation.

…lags like other call

weswigham

I'm not particularly worried about the perf - I think I only even used getSymbolAtLocation over getResolvedSymbol because a previous WIP version passed in non-identifier nodes (or I was explicitly looking for the ignoreErrors flag because at the time of it being very WIP, I needed it to cut down on the error diff).

The isExpressionNode change is the one that's a bit more iffy, since it'll affect other callsites (like the type baselines), but if that ends up having weird knock-on effects we can't predict, we can always undo that part and put an exception into the condition in checkSingleIdentifier specifically (since that's the place we definitely need it to behave like this). But @rbuckton might have more opinions on that, and weather the { name } in a shorthand property should truly count as an expression or not.

jakebailey · 2024-07-15T21:42:46Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-07-15T21:42:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-07-15T21:44:24Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162755/artifacts?artifactName=tgz&fileId=B34501455CD47CD8FC63C73EE5A64F096A0B1DC861328D8C5D76588BDB6C4B4202&fileName=/typescript-5.6.0-insiders.20240715.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2024-07-15T22:16:35Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-15T22:25:36Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59285/merge:

Everything looks good!

typescript-bot · 2024-07-15T22:31:41Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,779k (± 0.79%)}	_{192,251k (± 0.11%)}	_~	_192,091k	_192,520k	_{p=0.936 n=6}
_{Parse Time}	_{1.95s (± 0.71%)}	_{1.95s (± 0.99%)}	_~	_1.92s	_1.97s	_{p=0.459 n=6}
_{Bind Time}	_{1.06s (± 1.25%)}	_{1.05s (± 1.11%)}	_~	_1.04s	_1.07s	_{p=0.216 n=6}
_{Check Time}	_{13.82s (± 0.38%)}	_{13.83s (± 0.57%)}	_~	_13.75s	_13.94s	_{p=1.000 n=6}
_{Emit Time}	_{4.01s (± 0.49%)}	_{4.04s (± 0.79%)}	_~	_4.00s	_4.08s	_{p=0.077 n=6}
_{Total Time}	_{20.83s (± 0.22%)}	_{20.88s (± 0.41%)}	_~	_20.77s	_21.01s	_{p=0.374 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,120	_944,120	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,047	_407,047	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,367k (± 0.00%)}	_{1,218,352k (± 0.00%)}	_~	_1,218,313k	_1,218,385k	_{p=0.630 n=6}
_{Parse Time}	_{8.03s (± 0.57%)}	_{7.99s (± 0.54%)}	_~	_7.94s	_8.06s	_{p=0.295 n=6}
_{Bind Time}	_{2.23s (± 0.66%)}	_{2.22s (± 0.46%)}	_~	_2.21s	_2.24s	_{p=0.616 n=6}
_{Check Time}	_{35.85s (± 0.48%)}	_{35.91s (± 0.60%)}	_~	_35.62s	_36.20s	_{p=0.630 n=6}
_{Emit Time}	_{16.23s (± 0.60%)}	_{16.18s (± 0.32%)}	_~	_16.10s	_16.25s	_{p=0.747 n=6}
_{Total Time}	_{62.34s (± 0.38%)}	_{62.30s (± 0.33%)}	_~	_62.00s	_62.56s	_{p=0.873 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,249,830	_2,249,830	_~	_~	_~	_{p=1.000 n=6}
_Types	_937,437	_937,437	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,165,082k (± 0.00%)}	_{2,164,986k (± 0.01%)}	_~	_2,164,783k	_2,165,189k	_{p=0.230 n=6}
_{Parse Time}	_{9.66s (± 0.28%)}	_{9.67s (± 0.35%)}	_~	_9.61s	_9.70s	_{p=0.629 n=6}
_{Bind Time}	_{3.39s (± 0.51%)}	_{3.37s (± 0.74%)}	_~	_3.34s	_3.41s	_{p=0.192 n=6}
_{Check Time}	_{103.73s (± 0.48%)}	_{103.88s (± 0.60%)}	_~	_102.77s	_104.48s	_{p=0.423 n=6}
_{Emit Time}	_0.19s	_{0.20s (± 4.47%)}	_{🔻+0.01s (+ 5.26%)}	_0.19s	_0.21s	_{p=0.028 n=6}
_{Total Time}	_{116.97s (± 0.44%)}	_{117.11s (± 0.53%)}	_~	_116.02s	_117.73s	_{p=0.748 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,065	_1,226,065	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,603	_261,603	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,338,806k (± 0.02%)}	_{2,339,656k (± 0.05%)}	_~	_2,337,885k	_2,341,263k	_{p=0.378 n=6}
_{Parse Time}	_{6.06s (± 0.61%)}	_{6.07s (± 0.59%)}	_~	_6.01s	_6.11s	_{p=0.468 n=6}
_{Bind Time}	_{2.24s (± 0.56%)}	_{2.23s (± 0.62%)}	_~	_2.22s	_2.26s	_{p=0.459 n=6}
_{Check Time}	_{39.88s (± 0.34%)}	_{39.93s (± 0.22%)}	_~	_39.79s	_40.04s	_{p=0.688 n=6}
_{Emit Time}	_{3.83s (± 1.14%)}	_{3.81s (± 1.72%)}	_~	_3.72s	_3.92s	_{p=0.470 n=6}
_{Total Time}	_{52.02s (± 0.28%)}	_{52.06s (± 0.24%)}	_~	_51.90s	_52.23s	_{p=0.520 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,065	_1,226,065	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,603	_261,603	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,412,837k (± 0.01%)}	_{2,413,309k (± 0.02%)}	_~	_2,412,773k	_2,414,029k	_{p=0.066 n=6}
_{Parse Time}	_{6.33s (± 0.92%)}	_{6.34s (± 0.64%)}	_~	_6.28s	_6.39s	_{p=0.810 n=6}
_{Bind Time}	_{2.03s (± 1.01%)}	_{2.04s (± 0.90%)}	_~	_2.01s	_2.06s	_{p=0.331 n=6}
_{Check Time}	_{40.61s (± 0.24%)}	_{40.62s (± 0.34%)}	_~	_40.45s	_40.78s	_{p=0.810 n=6}
_{Emit Time}	_{3.90s (± 1.01%)}	_{3.88s (± 1.01%)}	_~	_3.82s	_3.92s	_{p=0.378 n=6}
_{Total Time}	_{52.87s (± 0.24%)}	_{52.87s (± 0.27%)}	_~	_52.68s	_53.06s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,309	_258,309	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,794	_104,794	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,140k (± 0.03%)}	_{427,066k (± 0.01%)}	_~	_427,015k	_427,123k	_{p=0.689 n=6}
_{Parse Time}	_{4.10s (± 0.28%)}	_{4.11s (± 0.57%)}	_~	_4.08s	_4.14s	_{p=0.934 n=6}
_{Bind Time}	_{1.63s (± 1.14%)}	_{1.62s (± 1.21%)}	_~	_1.59s	_1.64s	_{p=0.366 n=6}
_{Check Time}	_{22.08s (± 0.60%)}	_{22.14s (± 0.62%)}	_~	_21.99s	_22.30s	_{p=0.575 n=6}
_{Emit Time}	_{2.03s (± 0.86%)}	_{2.03s (± 1.41%)}	_~	_1.98s	_2.06s	_{p=0.805 n=6}
_{Total Time}	_{29.85s (± 0.42%)}	_{29.90s (± 0.60%)}	_~	_29.73s	_30.12s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,527k (± 0.02%)}	_{369,548k (± 0.02%)}	_~	_369,443k	_369,646k	_{p=0.748 n=6}
_{Parse Time}	_{3.42s (± 0.39%)}	_{3.42s (± 0.71%)}	_~	_3.38s	_3.45s	_{p=0.807 n=6}
_{Bind Time}	_{1.93s (± 0.53%)}	_{1.93s (± 0.85%)}	_~	_1.91s	_1.96s	_{p=0.802 n=6}
_{Check Time}	_{19.12s (± 0.29%)}	_{19.14s (± 0.28%)}	_~	_19.05s	_19.18s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.48s (± 0.24%)}	_{24.49s (± 0.21%)}	_~	_24.41s	_24.57s	_{p=0.746 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,891,299	_2,891,299	_~	_~	_~	_{p=1.000 n=6}
_Types	_978,316	_978,316	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,055,242k (± 0.00%)}	_{3,055,185k (± 0.00%)}	_~	_3,055,008k	_3,055,268k	_{p=0.471 n=6}
_{Parse Time}	_{16.98s (± 0.46%)}	_{16.95s (± 0.22%)}	_~	_16.91s	_17.00s	_{p=0.574 n=6}
_{Bind Time}	_{5.12s (± 0.61%)}	_{5.13s (± 0.20%)}	_~	_5.11s	_5.14s	_{p=0.250 n=6}
_{Check Time}	_{89.70s (± 0.39%)}	_{89.57s (± 0.42%)}	_~	_88.96s	_89.95s	_{p=0.423 n=6}
_{Emit Time}	_{29.30s (± 0.88%)}	_{29.19s (± 0.29%)}	_~	_29.06s	_29.29s	_{p=0.378 n=6}
_{Total Time}	_{141.09s (± 0.37%)}	_{140.84s (± 0.30%)}	_~	_140.22s	_141.25s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,280	_267,280	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,834	_108,834	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,757k (± 0.02%)}	_{411,768k (± 0.03%)}	_~	_411,637k	_411,911k	_{p=1.000 n=6}
_{Parse Time}	_{3.84s (± 0.37%)}	_{3.82s (± 0.46%)}	_~	_3.80s	_3.85s	_{p=0.162 n=6}
_{Bind Time}	_{1.69s (± 0.87%)}	_{1.70s (± 0.81%)}	_~	_1.68s	_1.71s	_{p=0.743 n=6}
_{Check Time}	_{16.71s (± 0.44%)}	_{16.76s (± 0.48%)}	_~	_16.62s	_16.85s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.25s (± 0.36%)}	_{22.28s (± 0.28%)}	_~	_22.18s	_22.36s	_{p=0.468 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,479	_510,479	_~	_~	_~	_{p=1.000 n=6}
_Types	_161,598	_161,598	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{448,302k (± 0.03%)}	_{448,247k (± 0.06%)}	_~	_447,674k	_448,439k	_{p=0.471 n=6}
_{Parse Time}	_{2.62s (± 0.67%)}	_{2.63s (± 0.57%)}	_~	_2.61s	_2.65s	_{p=0.284 n=6}
_{Bind Time}	_{0.98s (± 1.06%)}	_{0.98s (± 0.42%)}	_~	_0.97s	_0.98s	_{p=0.924 n=6}
_{Check Time}	_{14.41s (± 0.34%)}	_{14.41s (± 0.44%)}	_~	_14.36s	_14.50s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.01s (± 0.28%)}	_{18.03s (± 0.31%)}	_~	_17.98s	_18.12s	_{p=0.870 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-07-15T22:59:50Z

Preemptively sending this just so we don't forget:

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-07-15T22:59:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-07-15T23:02:19Z

Hey, @jakebailey! I've created #59288 for you.

typescript-bot · 2024-07-15T23:40:13Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59285/merge:

Everything looks good!

…e-5.5 (#59288) Co-authored-by: Jake Bailey <[email protected]>

rbuckton

There are quite a few types baseline changes that seem like an unintentional consequence of considering the name of a shorthand assignment as an expression.

tests/baselines/reference/shorthandOfExportedEntity02_targetES5_CommonJS.types

…i...) into release-5.5 (microsoft#59288)" This reverts commit 6c7df1f.

jakebailey · 2024-07-16T19:10:18Z

src/compiler/checker.ts

+        function isExpressionNodeOrShorthandPropertyAssignmentName(node: Identifier) {
+            // TODO(jakebailey): Just use isExpressionNode once that considers these identifiers to be expressions.
+            return isExpressionNode(node)
+                || isShorthandPropertyAssignment(node.parent) && (node.parent.objectAssignmentInitializer ?? node.parent.name) === node;


Here's the targeted fix.

…o release-5.5 (#59288)" (#59305)

jakebailey · 2024-07-16T19:16:47Z

src/compiler/utilities.ts

@@ -3550,6 +3550,7 @@ export function isInExpressionContext(node: Node): boolean {
        case SyntaxKind.ExpressionWithTypeArguments:
            return (parent as ExpressionWithTypeArguments).expression === node && !isPartOfTypeNode(parent);
        case SyntaxKind.ShorthandPropertyAssignment:
+            // TODO(jakebailey): it's possible that node could be the name, too


I plan to follow-up on this after merging; hoping that it's straightforwad to fix getTypeAtLocation to retain its old behavior.

jakebailey · 2024-07-16T19:46:14Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-07-16T19:46:17Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-07-16T19:48:52Z

Hey, @jakebailey! I've created #59307 for you.

…e-5.5 (#59307) Co-authored-by: Jake Bailey <[email protected]>

jakebailey added 3 commits July 15, 2024 13:14

Test

54003a5

Fix isInExpressionContext for name-only object prop shorthand

033a906

Use getResolvedSymbol to pass into checkIdentifierCalculateNodeCheckF…

7e1e976

…lags like other call

jakebailey requested a review from weswigham July 15, 2024 20:30

typescript-bot assigned jakebailey Jul 15, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 15, 2024

weswigham approved these changes Jul 15, 2024

View reviewed changes

jakebailey requested a review from rbuckton July 15, 2024 20:50

typescript-bot mentioned this pull request Jul 15, 2024

🤖 Pick PR #59285 (Fix captured shorthand properties i...) into release-5.5 #59288

Merged

DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024

🤖 Pick PR #59285 (Fix captured shorthand properties i...) into releas…

6c7df1f

…e-5.5 (#59288) Co-authored-by: Jake Bailey <[email protected]>

jakebailey added this to the TypeScript 5.5.4 milestone Jul 16, 2024

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 16, 2024

rbuckton reviewed Jul 16, 2024

View reviewed changes

tests/baselines/reference/shorthandOfExportedEntity02_targetES5_CommonJS.types Outdated Show resolved Hide resolved

jakebailey added a commit to jakebailey/TypeScript that referenced this pull request Jul 16, 2024

Revert "🤖 Pick PR microsoft#59285 (Fix captured shorthand properties …

519a528

…i...) into release-5.5 (microsoft#59288)" This reverts commit 6c7df1f.

jakebailey mentioned this pull request Jul 16, 2024

Revert "🤖 Pick PR #59285 (Fix captured shorthand properties i...) into release-5.5 (#59288)" #59305

Merged

jakebailey added 3 commits July 16, 2024 12:08

Revert isInExpressionContext change

f820ca5

Targeted fix

6c910bf

Smaller

66113d3

jakebailey commented Jul 16, 2024

View reviewed changes

jakebailey added a commit that referenced this pull request Jul 16, 2024

Revert "🤖 Pick PR #59285 (Fix captured shorthand properties i...) int…

afe1c32

…o release-5.5 (#59288)" (#59305)

rbuckton approved these changes Jul 16, 2024

View reviewed changes

jakebailey commented Jul 16, 2024

View reviewed changes

typescript-bot mentioned this pull request Jul 16, 2024

🤖 Pick PR #59285 (Fix captured shorthand properties i...) into release-5.5 #59307

Merged

jakebailey merged commit 003221b into microsoft:main Jul 16, 2024
29 checks passed

jakebailey deleted the fix-59262 branch July 16, 2024 20:30

DanielRosenwasser pushed a commit that referenced this pull request Jul 16, 2024

🤖 Pick PR #59285 (Fix captured shorthand properties i...) into releas…

315f9f9

…e-5.5 (#59307) Co-authored-by: Jake Bailey <[email protected]>

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix captured shorthand properties in ES2015 loops #59285

Fix captured shorthand properties in ES2015 loops #59285

jakebailey commented Jul 15, 2024 •

edited

Loading

weswigham left a comment

jakebailey commented Jul 15, 2024

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

tsc

jakebailey commented Jul 15, 2024

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

rbuckton left a comment

jakebailey Jul 16, 2024

jakebailey Jul 16, 2024

jakebailey commented Jul 16, 2024

typescript-bot commented Jul 16, 2024 •

edited

Loading

typescript-bot commented Jul 16, 2024

Fix captured shorthand properties in ES2015 loops #59285

Fix captured shorthand properties in ES2015 loops #59285

Conversation

jakebailey commented Jul 15, 2024 • edited Loading

weswigham left a comment

Choose a reason for hiding this comment

jakebailey commented Jul 15, 2024

typescript-bot commented Jul 15, 2024 • edited Loading

typescript-bot commented Jul 15, 2024 • edited Loading

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

tsc

jakebailey commented Jul 15, 2024

typescript-bot commented Jul 15, 2024 • edited Loading

typescript-bot commented Jul 15, 2024

typescript-bot commented Jul 15, 2024

rbuckton left a comment

Choose a reason for hiding this comment

jakebailey Jul 16, 2024

Choose a reason for hiding this comment

jakebailey Jul 16, 2024

Choose a reason for hiding this comment

jakebailey commented Jul 16, 2024

typescript-bot commented Jul 16, 2024 • edited Loading

typescript-bot commented Jul 16, 2024

jakebailey commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 15, 2024 •

edited

Loading

typescript-bot commented Jul 16, 2024 •

edited

Loading