Avoid checking class expressions more than once #59610

Andarist · 2024-08-12T20:54:52Z

When investigating #52892 I noticed that a class expression in the circular situation could be checked more than once.

I couldn't recognize any issue being fixed by this. I manually confirmed that various diagnostics could be created by this wrapped code more than once... but DiagnosticCollection['add'] uses a deduplication mechanism so this can't be observed.

typescript-bot · 2024-08-12T20:54:56Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

DanielRosenwasser · 2024-08-12T21:23:44Z

@typescript-bot test it

typescript-bot · 2024-08-12T21:23:47Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-08-12T21:44:46Z

Hey @DanielRosenwasser, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-08-12T21:49:17Z

@DanielRosenwasser Here are the results of running the user tests with tsc comparing main and refs/pull/59610/merge:

Everything looks good!

typescript-bot · 2024-08-12T22:00:20Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,539k (± 0.96%)}	_{192,933k (± 0.75%)}	_~	_192,311k	_195,877k	_{p=0.689 n=6}
_{Parse Time}	_{1.57s (± 0.94%)}	_{1.57s (± 0.77%)}	_~	_1.55s	_1.58s	_{p=0.564 n=6}
_{Bind Time}	_{0.86s (± 1.04%)}	_{0.86s (± 0.88%)}	_~	_0.85s	_0.87s	_{p=0.798 n=6}
_{Check Time}	_{11.37s (± 0.52%)}	_{11.39s (± 0.50%)}	_~	_11.34s	_11.50s	_{p=0.686 n=6}
_{Emit Time}	_{3.24s (± 0.23%)}	_{3.24s (± 0.86%)}	_~	_3.21s	_3.29s	_{p=1.000 n=6}
_{Total Time}	_{17.04s (± 0.41%)}	_{17.05s (± 0.39%)}	_~	_16.98s	_17.17s	_{p=0.810 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,757	_945,757	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,045	_410,045	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,542k (± 0.00%)}	_{1,222,558k (± 0.00%)}	_~	_1,222,519k	_1,222,587k	_{p=0.575 n=6}
_{Parse Time}	_{6.65s (± 0.42%)}	_{6.64s (± 0.28%)}	_~	_6.62s	_6.66s	_{p=0.804 n=6}
_{Bind Time}	_{1.87s (± 0.29%)}	_{1.86s (± 0.44%)}	_~	_1.85s	_1.87s	_{p=0.859 n=6}
_{Check Time}	_{31.12s (± 0.48%)}	_{31.08s (± 0.26%)}	_~	_30.96s	_31.21s	_{p=0.521 n=6}
_{Emit Time}	_{14.92s (± 0.79%)}	_{14.92s (± 0.83%)}	_~	_14.76s	_15.08s	_{p=0.687 n=6}
_{Total Time}	_{54.55s (± 0.30%)}	_{54.50s (± 0.18%)}	_~	_54.37s	_54.61s	_{p=0.520 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,491,074	_2,491,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,013,347	_1,013,347	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,498,062k (± 0.00%)}	_{2,498,085k (± 0.00%)}	_~	_2,498,009k	_2,498,177k	_{p=0.298 n=6}
_{Parse Time}	_{9.24s (± 0.35%)}	_{9.24s (± 0.34%)}	_~	_9.19s	_9.28s	_{p=0.571 n=6}
_{Bind Time}	_{2.18s (± 0.19%)}	_{2.18s (± 0.47%)}	_~	_2.17s	_2.20s	_{p=0.924 n=6}
_{Check Time}	_{75.86s (± 0.47%)}	_{75.69s (± 0.46%)}	_~	_75.20s	_76.12s	_{p=0.298 n=6}
_{Emit Time}	_{0.28s (± 2.26%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.718 n=6}
_{Total Time}	_{87.56s (± 0.40%)}	_{87.39s (± 0.43%)}	_~	_86.87s	_87.82s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,669	_1,229,670	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,082	_264,082	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,468,783k (±11.76%)}	_{2,349,859k (± 0.04%)}	_~	_2,348,974k	_2,351,171k	_{p=0.298 n=6}
_{Parse Time}	_{5.00s (± 1.31%)}	_{4.97s (± 0.59%)}	_~	_4.92s	_5.01s	_{p=0.378 n=6}
_{Bind Time}	_{1.87s (± 0.68%)}	_{1.89s (± 0.67%)}	_{+0.02s (+ 1.07%)}	_1.87s	_1.90s	_{p=0.040 n=6}
_{Check Time}	_{34.59s (± 0.69%)}	_{34.59s (± 0.14%)}	_~	_34.52s	_34.65s	_{p=0.872 n=6}
_{Emit Time}	_{3.29s (± 0.76%)}	_{3.30s (± 0.72%)}	_~	_3.27s	_3.32s	_{p=0.421 n=6}
_{Total Time}	_{44.77s (± 0.59%)}	_{44.77s (± 0.15%)}	_~	_44.67s	_44.87s	_{p=0.521 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,669	_1,229,670	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,082	_264,082	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,424,114k (± 0.01%)}	_{2,423,804k (± 0.01%)}	_~	_2,423,513k	_2,424,053k	_{p=0.128 n=6}
_{Parse Time}	_{5.15s (± 0.57%)}	_{5.14s (± 0.58%)}	_~	_5.10s	_5.16s	_{p=1.000 n=6}
_{Bind Time}	_{1.69s (± 0.45%)}	_{1.69s (± 0.48%)}	_~	_1.68s	_1.70s	_{p=0.729 n=6}
_{Check Time}	_{35.06s (± 0.32%)}	_{35.08s (± 0.30%)}	_~	_34.91s	_35.21s	_{p=0.936 n=6}
_{Emit Time}	_{3.36s (± 1.05%)}	_{3.37s (± 0.84%)}	_~	_3.33s	_3.41s	_{p=0.470 n=6}
_{Total Time}	_{45.26s (± 0.25%)}	_{45.27s (± 0.16%)}	_~	_45.16s	_45.35s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,825	_256,826	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,580	_105,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{429,127k (± 0.05%)}	_{429,056k (± 0.01%)}	_~	_429,022k	_429,125k	_{p=0.575 n=6}
_{Parse Time}	_{4.18s (± 0.72%)}	_{4.17s (± 0.46%)}	_~	_4.15s	_4.20s	_{p=0.807 n=6}
_{Bind Time}	_{1.62s (± 0.39%)}	_{1.62s (± 1.82%)}	_~	_1.57s	_1.65s	_{p=0.802 n=6}
_{Check Time}	_{22.25s (± 0.13%)}	_{22.27s (± 0.27%)}	_~	_22.17s	_22.36s	_{p=0.368 n=6}
_{Emit Time}	_{2.06s (± 1.29%)}	_{2.05s (± 0.37%)}	_~	_2.04s	_2.06s	_{p=0.869 n=6}
_{Total Time}	_{30.10s (± 0.19%)}	_{30.10s (± 0.22%)}	_~	_30.00s	_30.17s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,245	_94,245	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,234k (± 0.03%)}	_{370,110k (± 0.01%)}	_{-124k (- 0.03%)}	_370,026k	_370,146k	_{p=0.045 n=6}
_{Parse Time}	_{2.75s (± 1.16%)}	_{2.75s (± 1.14%)}	_~	_2.71s	_2.79s	_{p=0.809 n=6}
_{Bind Time}	_{1.56s (± 0.48%)}	_{1.56s (± 0.63%)}	_~	_1.55s	_1.57s	_{p=1.000 n=6}
_{Check Time}	_{15.68s (± 0.17%)}	_{15.65s (± 0.29%)}	_~	_15.59s	_15.72s	_{p=0.199 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.99s (± 0.18%)}	_{19.96s (± 0.18%)}	_~	_19.90s	_20.00s	_{p=0.256 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,999,114	_2,999,114	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,033,196	_1,033,182	_{-14 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,124,370k (± 0.00%)}	_{3,124,335k (± 0.00%)}	_~	_3,124,240k	_3,124,413k	_{p=0.378 n=6}
_{Parse Time}	_{13.83s (± 0.40%)}	_{13.82s (± 0.38%)}	_~	_13.74s	_13.86s	_{p=0.872 n=6}
_{Bind Time}	_{4.32s (± 1.94%)}	_{4.31s (± 2.36%)}	_~	_4.23s	_4.51s	_{p=0.683 n=6}
_{Check Time}	_{79.69s (± 0.38%)}	_{79.57s (± 0.60%)}	_~	_79.12s	_80.41s	_{p=0.471 n=6}
_{Emit Time}	_{20.47s (± 0.87%)}	_{20.27s (± 0.36%)}	_~	_20.17s	_20.36s	_{p=0.078 n=6}
_{Total Time}	_{118.31s (± 0.32%)}	_{117.96s (± 0.38%)}	_~	_117.48s	_118.69s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_274,227	_274,208	_{-19 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_111,803	_111,642	_{-161 (- 0.14%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{420,646k (± 0.02%)}	_{420,438k (± 0.02%)}	_{-208k (- 0.05%)}	_420,369k	_420,561k	_{p=0.008 n=6}
_{Parse Time}	_{4.89s (± 0.60%)}	_{4.89s (± 0.53%)}	_~	_4.85s	_4.92s	_{p=1.000 n=6}
_{Bind Time}	_{2.12s (± 0.64%)}	_{2.15s (± 0.48%)}	_{+0.03s (+ 1.41%)}	_2.14s	_2.17s	_{p=0.013 n=6}
_{Check Time}	_{21.21s (± 0.16%)}	_{21.24s (± 0.51%)}	_~	_21.06s	_21.37s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.23s (± 0.12%)}	_{28.28s (± 0.41%)}	_~	_28.11s	_28.44s	_{p=0.334 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,779	_540,779	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,884	_177,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,281k (± 0.01%)}	_{483,285k (± 0.01%)}	_~	_483,201k	_483,386k	_{p=0.936 n=6}
_{Parse Time}	_{4.27s (± 0.57%)}	_{4.26s (± 0.52%)}	_~	_4.23s	_4.29s	_{p=0.571 n=6}
_{Bind Time}	_{1.55s (± 0.63%)}	_{1.54s (± 1.04%)}	_~	_1.52s	_1.56s	_{p=0.446 n=6}
_{Check Time}	_{22.36s (± 0.28%)}	_{22.39s (± 0.47%)}	_~	_22.26s	_22.56s	_{p=0.568 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.17s (± 0.21%)}	_{28.19s (± 0.38%)}	_~	_28.06s	_28.37s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-08-12T23:10:41Z

@DanielRosenwasser Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59610/merge:

Everything looks good!

Avoid checking class expressions more than once

8a1422c

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid checking class expressions more than once #59610

Avoid checking class expressions more than once #59610

Andarist commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

DanielRosenwasser commented Aug 12, 2024

typescript-bot commented Aug 12, 2024 •

edited

Loading

typescript-bot commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

tsc

typescript-bot commented Aug 12, 2024

Avoid checking class expressions more than once #59610

Are you sure you want to change the base?

Avoid checking class expressions more than once #59610

Conversation

Andarist commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

DanielRosenwasser commented Aug 12, 2024

typescript-bot commented Aug 12, 2024 • edited Loading

typescript-bot commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

typescript-bot commented Aug 12, 2024

tsc

typescript-bot commented Aug 12, 2024

typescript-bot commented Aug 12, 2024 •

edited

Loading