Fixed JSDoc checking on enum members #61184

Andarist · 2025-02-15T19:00:01Z

jakebailey · 2025-02-20T00:40:50Z

This feels right, though makes me wonder if we have this same problem in other cases?

typescript-bot · 2025-02-20T00:40:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-20T01:05:03Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-20T01:26:01Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61184/merge:

Everything looks good!

typescript-bot · 2025-02-20T01:26:31Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,973k (± 0.07%)}	_{194,244k (± 0.91%)}	_~	_192,919k	_196,546k	_{p=0.109 n=6}
_{Parse Time}	_{1.30s (± 1.17%)}	_{1.31s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=0.187 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.71s (± 0.49%)}	_{9.75s (± 0.41%)}	_~	_9.71s	_9.82s	_{p=0.127 n=6}
_{Emit Time}	_{2.74s (± 0.61%)}	_{2.75s (± 0.30%)}	_~	_2.74s	_2.76s	_{p=0.546 n=6}
_{Total Time}	_{14.48s (± 0.40%)}	_{14.53s (± 0.34%)}	_~	_14.48s	_14.62s	_{p=0.128 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,251k (± 0.01%)}	_{1,224,200k (± 0.00%)}	_~	_1,224,149k	_1,224,257k	_{p=0.230 n=6}
_{Parse Time}	_{6.67s (± 0.48%)}	_{6.63s (± 0.69%)}	_~	_6.57s	_6.67s	_{p=0.226 n=6}
_{Bind Time}	_{1.88s (± 0.91%)}	_{1.89s (± 0.62%)}	_~	_1.87s	_1.90s	_{p=0.563 n=6}
_{Check Time}	_{31.80s (± 0.33%)}	_{31.81s (± 0.22%)}	_~	_31.75s	_31.92s	_{p=1.000 n=6}
_{Emit Time}	_{15.26s (± 0.36%)}	_{15.22s (± 0.23%)}	_~	_15.16s	_15.25s	_{p=0.064 n=6}
_{Total Time}	_{55.61s (± 0.26%)}	_{55.55s (± 0.16%)}	_~	_55.40s	_55.66s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,891	_2,347,891	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,644	_845,644	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,574k (± 0.01%)}	_{2,120,504k (± 0.01%)}	_~	_2,120,344k	_2,120,640k	_{p=0.378 n=6}
_{Parse Time}	_{8.73s (± 0.72%)}	_{8.83s (± 1.64%)}	_~	_8.73s	_9.12s	_{p=0.149 n=6}
_{Bind Time}	_{2.93s (± 0.95%)}	_{2.81s (± 7.82%)}	_~	_2.37s	_2.95s	_{p=0.148 n=6}
_{Check Time}	_{85.87s (± 1.70%)}	_{86.53s (± 1.12%)}	_~	_85.83s	_88.45s	_{p=0.810 n=6}
_{Emit Time}	_{0.20s (± 4.15%)}	_{0.20s (± 6.58%)}	_~	_0.19s	_0.22s	_{p=0.604 n=6}
_{Total Time}	_{97.73s (± 1.46%)}	_{98.38s (± 0.91%)}	_~	_97.67s	_100.14s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,510	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,358,438k (± 0.03%)}	_{2,358,435k (± 0.02%)}	_~	_2,358,008k	_2,359,064k	_{p=0.873 n=6}
_{Parse Time}	_{5.20s (± 0.73%)}	_{5.17s (± 0.46%)}	_~	_5.13s	_5.19s	_{p=0.199 n=6}
_{Bind Time}	_{1.79s (± 0.91%)}	_{1.77s (± 1.01%)}	_~	_1.75s	_1.80s	_{p=0.053 n=6}
_{Check Time}	_{35.20s (± 0.22%)}	_{35.23s (± 0.18%)}	_~	_35.15s	_35.32s	_{p=0.575 n=6}
_{Emit Time}	_{3.00s (± 1.47%)}	_{2.97s (± 0.84%)}	_~	_2.94s	_3.01s	_{p=0.335 n=6}
_{Total Time}	_{45.19s (± 0.29%)}	_{45.14s (± 0.23%)}	_~	_45.04s	_45.33s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,510	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,154,147k (± 0.01%)}	_{3,033,925k (± 9.75%)}	_~	_2,429,443k	_3,155,854k	_{p=0.575 n=6}
_{Parse Time}	_{6.99s (± 0.55%)}	_{6.96s (± 0.86%)}	_~	_6.85s	_7.01s	_{p=0.688 n=6}
_{Bind Time}	_{2.13s (± 1.01%)}	_{2.13s (± 1.59%)}	_~	_2.08s	_2.17s	_{p=0.630 n=6}
_{Check Time}	_{42.90s (± 0.28%)}	_{42.74s (± 0.31%)}	_~	_42.55s	_42.87s	_{p=0.066 n=6}
_{Emit Time}	_{3.51s (± 1.66%)}	_{3.47s (± 2.37%)}	_~	_3.34s	_3.56s	_{p=0.470 n=6}
_{Total Time}	_{55.52s (± 0.32%)}	_{55.32s (± 0.42%)}	_~	_55.04s	_55.61s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,816	_262,816	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,833	_106,833	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,321k (± 0.01%)}	_{440,289k (± 0.01%)}	_~	_440,234k	_440,328k	_{p=0.148 n=6}
_{Parse Time}	_{2.88s (± 0.74%)}	_{2.88s (± 0.48%)}	_~	_2.87s	_2.90s	_{p=0.566 n=6}
_{Bind Time}	_1.11s	_1.11s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.76s (± 0.51%)}	_{15.72s (± 0.20%)}	_~	_15.68s	_15.76s	_{p=0.126 n=6}
_{Emit Time}	_{1.27s (± 1.07%)}	_{1.29s (± 1.50%)}	_~	_1.26s	_1.31s	_{p=0.195 n=6}
_{Total Time}	_{21.03s (± 0.46%)}	_{21.01s (± 0.10%)}	_~	_20.97s	_21.03s	_{p=0.297 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,390k (± 0.03%)}	_{371,378k (± 0.04%)}	_~	_371,276k	_371,656k	_{p=0.298 n=6}
_{Parse Time}	_{2.89s (± 1.15%)}	_{2.88s (± 0.94%)}	_~	_2.84s	_2.91s	_{p=1.000 n=6}
_{Bind Time}	_{1.58s (± 1.30%)}	_{1.60s (± 1.16%)}	_~	_1.58s	_1.63s	_{p=0.089 n=6}
_{Check Time}	_{16.42s (± 0.46%)}	_{16.44s (± 0.39%)}	_~	_16.37s	_16.53s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.89s (± 0.49%)}	_{20.93s (± 0.30%)}	_~	_20.87s	_21.04s	_{p=0.196 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,220,984	_3,220,984	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,092,532	_1,092,532	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,296,438k (± 0.01%)}	_{3,296,256k (± 0.01%)}	_~	_3,295,841k	_3,296,630k	_{p=0.298 n=6}
_{Parse Time}	_{14.35s (± 0.54%)}	_{14.27s (± 1.03%)}	_~	_14.09s	_14.50s	_{p=0.228 n=6}
_{Bind Time}	_{4.58s (± 0.61%)}	_{4.85s (±12.85%)}	_~	_4.57s	_6.12s	_{p=0.294 n=6}
_{Check Time}	_{89.82s (± 2.00%)}	_{89.51s (± 1.82%)}	_~	_87.65s	_91.66s	_{p=0.873 n=6}
_{Emit Time}	_{27.63s (± 2.04%)}	_{25.80s (± 8.71%)}	_~	_22.89s	_27.70s	_{p=0.298 n=6}
_{Total Time}	_{136.38s (± 1.26%)}	_{134.43s (± 0.91%)}	_~	_132.68s	_136.20s	_{p=0.078 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,617	_119,617	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,176k (± 0.02%)}	_{447,159k (± 0.02%)}	_~	_446,996k	_447,259k	_{p=0.810 n=6}
_{Parse Time}	_{4.09s (± 1.16%)}	_{4.07s (± 0.87%)}	_~	_4.02s	_4.11s	_{p=0.630 n=6}
_{Bind Time}	_{1.76s (± 1.17%)}	_{1.76s (± 0.84%)}	_~	_1.73s	_1.77s	_{p=0.740 n=6}
_{Check Time}	_{18.76s (± 0.58%)}	_{18.76s (± 0.57%)}	_~	_18.66s	_18.92s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.62s (± 0.37%)}	_{24.59s (± 0.48%)}	_~	_24.44s	_24.76s	_{p=0.572 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_558,084	_558,084	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,415	_186,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{495,034k (± 0.01%)}	_{495,084k (± 0.01%)}	_~	_495,059k	_495,119k	_{p=0.054 n=6}
_{Parse Time}	_{3.41s (± 0.65%)}	_{3.43s (± 0.75%)}	_~	_3.39s	_3.47s	_{p=0.103 n=6}
_{Bind Time}	_{1.19s (± 1.34%)}	_{1.19s (± 1.11%)}	_~	_1.17s	_1.21s	_{p=1.000 n=6}
_{Check Time}	_{19.62s (± 0.40%)}	_{19.57s (± 0.29%)}	_~	_19.49s	_19.64s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.22s (± 0.43%)}	_{24.19s (± 0.20%)}	_~	_24.13s	_24.27s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-20T02:35:10Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61184/merge:

Everything looks good!

Fixed JSDoc checking on enum members

7304216

jakebailey approved these changes Feb 20, 2025

View reviewed changes

jakebailey merged commit 5695986 into microsoft:main Feb 20, 2025
32 checks passed

sandersn removed this from PR Backlog Apr 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed JSDoc checking on enum members #61184

Fixed JSDoc checking on enum members #61184

Uh oh!

Andarist commented Feb 15, 2025

Uh oh!

jakebailey commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

tsc

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

Fixed JSDoc checking on enum members #61184

Fixed JSDoc checking on enum members #61184

Uh oh!

Conversation

Andarist commented Feb 15, 2025

Uh oh!

jakebailey commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

tsc

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Feb 20, 2025 •

edited

Loading