Function initializers as properties #61636
Open
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
There was a problem hiding this comment.
Pull Request Overview
This PR updates the binder logic for expando initializers when they are function‐like, distinguishing between prototype properties and non‑prototype properties.
- When the expando is assigned to a prototype, only the Method flag is set; otherwise, both Method and Property flags are combined.
sandersn
requested changes
May 2, 2025
| excludes = SymbolFlags.MethodExcludes; | ||
| } | ||
| else { | ||
| includes = SymbolFlags.Method | SymbolFlags.Property; |
There was a problem hiding this comment.
This should just be Property, I'm pretty sure. They're a function property, but don't have useful this semantics, static vs instance distinction, etc.
| @@ -3491,8 +3491,14 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void { | |||
| let excludes = SymbolFlags.None; | |||
| // Method-like | |||
| if (isFunctionLikeDeclaration(getAssignedExpandoInitializer(declaration)!)) { | |||
There was a problem hiding this comment.
Since you don't need a custom includes you can reduce this code change down to
Suggested change
| if (isFunctionLikeDeclaration(getAssignedExpandoInitializer(declaration)!)) { | |
| if (isPrototypeProperty && isFunctionLikeDeclaration(getAssignedExpandoInitializer(declaration)!)) { |
and the default case at the bottom of the function will apply.
github-project-automation
bot
moved this from Not started
to Waiting on author
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59112