Skip to content

Add check for unknown type #61810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add check for unknown type #61810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2c6818
Return an error if either the left or right value are of type boolean
May 23, 2025
1bd2289
Merge branch 'microsoft:main' into main
CamBoyd Jun 3, 2025
0dd8b23
Add check for unknown type
Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12975,7 +12975,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
const s = signatures[0];
if (!s.typeParameters && s.parameters.length === 1 && signatureHasRestParameter(s)) {
const paramType = getTypeOfParameter(s.parameters[0]);
return isTypeAny(paramType) || getElementTypeOfArrayType(paramType) === anyType;
return isTypeAny(paramType) || getElementTypeOfArrayType(paramType) === anyType || getElementTypeOfArrayType(paramType) === unknownType;
}
}
return false;
Expand Down Expand Up @@ -40116,6 +40116,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
return sourceType;
}

function isBoolean(value: any): boolean {
return (value === typeof "boolean");
}

/**
* This is a *shallow* check: An expression is side-effect-free if the
* evaluation of the expression *itself* cannot produce side effects.
Expand Down Expand Up @@ -40612,6 +40616,9 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
leftType = getBaseTypeOfLiteralTypeForComparison(checkNonNullType(leftType, left));
rightType = getBaseTypeOfLiteralTypeForComparison(checkNonNullType(rightType, right));
reportOperatorErrorUnless((left, right) => {
if (isBoolean(left) || isBoolean(right)) {
return true;
}
Comment on lines +40619 to +40621
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated?

if (isTypeAny(left) || isTypeAny(right)) {
return true;
}
Expand Down