Port "Improve type discrimination algorithm" from tsgo #61828

jakebailey · 2025-06-07T16:06:24Z

Porting microsoft/typescript-go#1085 for testing.

jakebailey · 2025-06-07T16:06:36Z

typescript-bot · 2025-06-07T16:06:40Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-06-07T16:29:36Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-06-07T16:32:24Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61828/merge:

Everything looks good!

typescript-bot · 2025-06-07T16:55:28Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,193k (± 0.99%)}	_{193,587k (± 0.74%)}	_~	_192,911k	_196,515k	_{p=0.336 n=6}
_{Parse Time}	_{1.31s (± 0.94%)}	_{1.30s (± 1.02%)}	_~	_1.29s	_1.32s	_{p=0.729 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.72s (± 0.34%)}	_{9.72s (± 0.33%)}	_~	_9.68s	_9.75s	_{p=0.871 n=6}
_{Emit Time}	_{2.74s (± 0.63%)}	_{2.74s (± 0.67%)}	_~	_2.71s	_2.76s	_{p=0.935 n=6}
_{Total Time}	_{14.49s (± 0.26%)}	_{14.49s (± 0.28%)}	_~	_14.44s	_14.55s	_{p=0.871 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_949,249	_949,301	_{+52 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_411,061	_411,047	_{-14 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,134k (± 0.01%)}	_{1,225,182k (± 0.01%)}	_~	_1,225,073k	_1,225,291k	_{p=0.378 n=6}
_{Parse Time}	_{6.60s (± 0.79%)}	_{6.62s (± 0.41%)}	_~	_6.60s	_6.67s	_{p=0.935 n=6}
_{Bind Time}	_{1.88s (± 0.22%)}	_{1.88s (± 0.67%)}	_~	_1.87s	_1.90s	_{p=0.930 n=6}
_{Check Time}	_{31.97s (± 0.28%)}	_{31.94s (± 0.47%)}	_~	_31.77s	_32.10s	_{p=0.810 n=6}
_{Emit Time}	_{14.85s (± 0.31%)}	_{14.88s (± 0.30%)}	_~	_14.82s	_14.92s	_{p=0.229 n=6}
_{Total Time}	_{55.29s (± 0.15%)}	_{55.32s (± 0.35%)}	_~	_55.08s	_55.56s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,576,529	_2,576,529	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,130	_892,131	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,856,921k (± 0.00%)}	_{2,856,927k (± 0.00%)}	_~	_2,856,871k	_2,856,977k	_{p=0.873 n=6}
_{Parse Time}	_{9.08s (± 0.16%)}	_{9.10s (± 0.54%)}	_~	_9.04s	_9.18s	_{p=0.571 n=6}
_{Bind Time}	_{2.29s (± 0.45%)}	_{2.29s (± 0.36%)}	_~	_2.27s	_2.29s	_{p=1.000 n=6}
_{Check Time}	_{87.32s (± 0.51%)}	_{87.31s (± 0.49%)}	_~	_86.75s	_87.71s	_{p=0.810 n=6}
_{Emit Time}	_{0.30s (± 1.37%)}	_{0.30s (± 1.37%)}	_~	_0.29s	_0.30s	_{p=1.000 n=6}
_{Total Time}	_{98.98s (± 0.44%)}	_{99.00s (± 0.48%)}	_~	_98.35s	_99.42s	_{p=0.936 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₂	_{🔻+2 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_1,228,901	_1,294,261	_{🔻+65,360 (+ 5.32%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,535	_267,636	_{+101 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,361,874k (± 0.02%)}	_{2,516,279k (± 0.02%)}	_{🔻+154,405k (+ 6.54%)}	_2,515,472k	_2,516,733k	_{p=0.005 n=6}
_{Parse Time}	_{5.20s (± 0.87%)}	_{6.80s (± 0.42%)}	_{🔻+1.60s (+30.84%)}	_6.77s	_6.84s	_{p=0.005 n=6}
_{Bind Time}	_{1.81s (± 0.57%)}	_{2.55s (± 0.32%)}	_{🔻+0.74s (+40.81%)}	_2.54s	_2.56s	_{p=0.004 n=6}
_{Check Time}	_{35.49s (± 0.42%)}	_{35.47s (± 0.23%)}	_~	_35.34s	_35.56s	_{p=0.689 n=6}
_{Emit Time}	_{3.03s (± 2.68%)}	_{2.97s (± 0.59%)}	_~	_2.96s	_3.00s	_{p=0.146 n=6}
_{Total Time}	_{45.55s (± 0.45%)}	_{47.81s (± 0.20%)}	_{🔻+2.26s (+ 4.97%)}	_47.65s	_47.91s	_{p=0.005 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₂	_{🔻+2 (+ ∞%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_1,228,901	_1,294,261	_{🔻+65,360 (+ 5.32%)}	_~	_~	_{p=0.001 n=6}
_Types	_267,535	_267,636	_{+101 (+ 0.04%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,041,141k (± 9.82%)}	_{2,834,586k (±13.30%)}	_~	_2,588,798k	_3,321,773k	_{p=0.810 n=6}
_{Parse Time}	_{6.91s (± 1.21%)}	_{8.77s (± 0.96%)}	_{🔻+1.86s (+26.90%)}	_8.67s	_8.91s	_{p=0.005 n=6}
_{Bind Time}	_{2.20s (± 2.06%)}	_{3.07s (± 0.90%)}	_{🔻+0.87s (+39.65%)}	_3.03s	_3.11s	_{p=0.005 n=6}
_{Check Time}	_{43.03s (± 0.54%)}	_{42.95s (± 0.55%)}	_~	_42.63s	_43.30s	_{p=0.471 n=6}
_{Emit Time}	_{3.47s (± 2.34%)}	_{3.53s (± 4.65%)}	_~	_3.36s	_3.75s	_{p=0.810 n=6}
_{Total Time}	_{55.60s (± 0.45%)}	_{58.32s (± 0.58%)}	_{🔻+2.72s (+ 4.90%)}	_57.90s	_58.84s	_{p=0.005 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,517	_263,517	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,246	_107,248	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{442,131k (± 0.01%)}	_{442,122k (± 0.02%)}	_~	_442,047k	_442,237k	_{p=0.810 n=6}
_{Parse Time}	_{3.53s (± 0.58%)}	_{3.53s (± 1.00%)}	_~	_3.50s	_3.60s	_{p=0.871 n=6}
_{Bind Time}	_{1.32s (± 1.17%)}	_{1.33s (± 0.57%)}	_~	_1.32s	_1.34s	_{p=0.404 n=6}
_{Check Time}	_{18.96s (± 0.20%)}	_{19.02s (± 0.44%)}	_~	_18.88s	_19.12s	_{p=0.148 n=6}
_{Emit Time}	_{1.52s (± 0.80%)}	_{1.52s (± 0.72%)}	_~	_1.51s	_1.54s	_{p=0.739 n=6}
_{Total Time}	_{25.33s (± 0.23%)}	_{25.39s (± 0.42%)}	_~	_25.21s	_25.52s	_{p=0.127 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,358	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{371,347k (± 0.03%)}	_{371,444k (± 0.06%)}	_~	_371,244k	_371,814k	_{p=0.810 n=6}
_{Parse Time}	_{2.90s (± 0.72%)}	_{2.88s (± 1.34%)}	_~	_2.82s	_2.94s	_{p=0.466 n=6}
_{Bind Time}	_{1.60s (± 1.46%)}	_{1.59s (± 1.42%)}	_~	_1.56s	_1.61s	_{p=0.415 n=6}
_{Check Time}	_{16.48s (± 0.31%)}	_{16.47s (± 0.54%)}	_~	_16.35s	_16.60s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.99s (± 0.22%)}	_{20.94s (± 0.33%)}	_~	_20.85s	_21.06s	_{p=0.227 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₈	₃₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,495,853	_3,495,854	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,180,300	_1,180,350	_{+50 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,537,292k (± 0.00%)}	_{3,537,503k (± 0.01%)}	_~	_3,536,893k	_3,538,175k	_{p=0.173 n=6}
_{Parse Time}	_{14.98s (± 0.67%)}	_{14.99s (± 0.30%)}	_~	_14.93s	_15.04s	_{p=0.936 n=6}
_{Bind Time}	_{4.89s (± 0.86%)}	_{4.86s (± 0.50%)}	_~	_4.81s	_4.88s	_{p=0.122 n=6}
_{Check Time}	_{97.43s (± 3.52%)}	_{95.48s (± 1.55%)}	_~	_94.23s	_97.53s	_{p=0.471 n=6}
_{Emit Time}	_{32.24s (±14.15%)}	_{30.59s (± 8.24%)}	_~	_29.18s	_35.60s	_{p=0.128 n=6}
_{Total Time}	_{149.54s (± 3.85%)}	_{145.91s (± 2.57%)}	_~	_143.27s	_152.63s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_320,092	_320,092	_~	_~	_~	_{p=1.000 n=6}
_Types	_140,399	_140,403	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{474,330k (± 0.03%)}	_{474,396k (± 0.02%)}	_~	_474,254k	_474,521k	_{p=0.378 n=6}
_{Parse Time}	_{4.33s (± 1.04%)}	_{4.32s (± 0.48%)}	_~	_4.30s	_4.36s	_{p=0.872 n=6}
_{Bind Time}	_{1.77s (± 1.49%)}	_{1.77s (± 1.17%)}	_~	_1.73s	_1.79s	_{p=0.935 n=6}
_{Check Time}	_{20.80s (± 0.45%)}	_{20.78s (± 0.63%)}	_~	_20.64s	_20.94s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.90s (± 0.43%)}	_{26.88s (± 0.50%)}	_~	_26.71s	_27.04s	_{p=0.688 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₃₅	_{🔻+30 (+600.00%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_560,615	_560,725	_{+110 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_191,464	_191,950	_{+486 (+ 0.25%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{498,464k (± 0.03%)}	_{499,007k (± 0.01%)}	_{+544k (+ 0.11%)}	_498,957k	_499,051k	_{p=0.005 n=6}
_{Parse Time}	_{3.44s (± 0.89%)}	_{3.43s (± 0.86%)}	_~	_3.39s	_3.46s	_{p=0.872 n=6}
_{Bind Time}	_{1.24s (± 1.10%)}	_{1.23s (± 1.58%)}	_~	_1.20s	_1.25s	_{p=0.440 n=6}
_{Check Time}	_{19.71s (± 1.42%)}	_{19.57s (± 0.36%)}	_~	_19.48s	_19.68s	_{p=0.258 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.39s (± 1.25%)}	_{24.23s (± 0.26%)}	_~	_24.17s	_24.31s	_{p=0.260 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-06-07T18:01:27Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61828/merge:

Everything looks good!

jakebailey · 2025-06-07T18:17:31Z

Despite the above, xstate has 30 new errors.

Port "Improve type discrimination algorithm" from tsgo

6055f1d

typescript-bot assigned jakebailey Jun 7, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 7, 2025

jakebailey mentioned this pull request Jun 7, 2025

Improve type discrimination algorithm microsoft/typescript-go#1085

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port "Improve type discrimination algorithm" from tsgo #61828

Port "Improve type discrimination algorithm" from tsgo #61828

jakebailey commented Jun 7, 2025

Uh oh!

jakebailey commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025

tsc

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

jakebailey commented Jun 7, 2025

Uh oh!

Uh oh!

Port "Improve type discrimination algorithm" from tsgo #61828

Are you sure you want to change the base?

Port "Improve type discrimination algorithm" from tsgo #61828

Conversation

jakebailey commented Jun 7, 2025

Uh oh!

jakebailey commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

typescript-bot commented Jun 7, 2025

tsc

Uh oh!

typescript-bot commented Jun 7, 2025

Uh oh!

jakebailey commented Jun 7, 2025

Uh oh!

Uh oh!

typescript-bot commented Jun 7, 2025 •

edited

Loading