Skip to content

Remove no-default-lib #62435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 8 commits into from
Sep 24, 2025
Merged

Remove no-default-lib #62435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c04133d
Remove no-default-lib support
jakebailey Sep 12, 2025
db2decd
Update baselines
jakebailey Sep 12, 2025
7675ba5
Move libFiles.add
jakebailey Sep 12, 2025
f0c60dc
Simplify default lib file
jakebailey Sep 22, 2025
a2ffa94
lint
jakebailey Sep 22, 2025
d636a2e
Speed up sanitizeLibFileText
jakebailey Sep 23, 2025
158ef1d
fmt
jakebailey Sep 23, 2025
25d054c
Fix up test to match old behavior
jakebailey Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/harness/harnessIO.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,24 +233,27 @@ export namespace Compiler {
export const es2015DefaultLibFileName = "lib.es2015.d.ts";

// Cache of lib files from "built/local"
export let libFileNameSourceFileMap: Map<string, ts.SourceFile> | undefined;
export let libFileNameSourceFileMap: Map<string, { file: ts.SourceFile; stringified: string; }> | undefined;

export function getDefaultLibrarySourceFile(fileName: string = defaultLibFileName): ts.SourceFile | undefined {
if (!isDefaultLibraryFile(fileName)) {
return undefined;
}

if (!libFileNameSourceFileMap) {
const file = createSourceFileAndAssertInvariants(defaultLibFileName, IO.readFile(libFolder + "lib.es5.d.ts")!, /*languageVersion*/ ts.ScriptTarget.Latest);
libFileNameSourceFileMap = new Map(Object.entries({
[defaultLibFileName]: createSourceFileAndAssertInvariants(defaultLibFileName, IO.readFile(libFolder + "lib.es5.d.ts")!, /*languageVersion*/ ts.ScriptTarget.Latest),
[defaultLibFileName]: { file, stringified: JSON.stringify(file.text) },
}));
}

let sourceFile = libFileNameSourceFileMap.get(fileName);
if (!sourceFile) {
libFileNameSourceFileMap.set(fileName, sourceFile = createSourceFileAndAssertInvariants(fileName, IO.readFile(libFolder + fileName)!, ts.ScriptTarget.Latest));
const file = createSourceFileAndAssertInvariants(fileName, IO.readFile(libFolder + fileName)!, ts.ScriptTarget.Latest)
sourceFile = { file, stringified: JSON.stringify(file.text) };
libFileNameSourceFileMap.set(fileName, sourceFile);
}
return sourceFile;
return sourceFile.file;
}

export function getDefaultLibFileName(options: ts.CompilerOptions): string {
Expand Down
4 changes: 2 additions & 2 deletions src/harness/tsserverLogger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ function sanitizeHarnessLSException(s: string) {

export function sanitizeLibFileText(s: string): string {
Compiler.libFileNameSourceFileMap?.forEach((lib, fileName) => {
s = replaceAll(s, JSON.stringify(lib.text), `${fileName}-Text`);
s = replaceAll(s, lib.text, `${fileName}-Text`);
s = replaceAll(s, lib.stringified, `${fileName}-Text`);
s = replaceAll(s, lib.file.text, `${fileName}-Text`);
Comment on lines +147 to +148
Copy link
Member Author

@jakebailey jakebailey Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stringify accounted for a large amount of runtime as more files are being loaded in the tests; moving it fixes the test perf issue.

});
return s;
}
Expand Down
Loading