Skip to content

Adds the JSX transformer #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Mar 18, 2016
Merged

Conversation

rbuckton
Copy link
Member

The JSX transformer is designed to transform JSX-specific syntax into compatible JavaScript when the --jsx react compiler option.

Related Pull Requests:

Review on Reviewable

@rbuckton rbuckton changed the title Transforms transformer jsx Adds the JSX transformer Feb 23, 2016
@RyanCavanaugh
Copy link
Member

Am I reading this correctly that there are zero baseline changes?

@rbuckton
Copy link
Member Author

@RyanCavanaugh With only these transformations, the emitter isn't far enough along to run the tests and capture baseline changes. Those will come after I submit the last PR containing the module transformer.

let pos = 0;
while (start < len) {
while (pos < len) {
const value = array[pos];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this temp is needed for readability or efficiency.

@sandersn
Copy link
Member

sandersn commented Mar 2, 2016

👍

rbuckton added a commit that referenced this pull request Mar 18, 2016
@rbuckton rbuckton merged commit 829a9df into transforms-transformer-ts Mar 18, 2016
@rbuckton rbuckton deleted the transforms-transformer-jsx branch March 18, 2016 22:47
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants