Skip to content

Add test for #7301 #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4 commits merged into from
May 17, 2016
Merged

Add test for #7301 #8622

4 commits merged into from
May 17, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2016

Resolves #7301

@msftclas
Copy link

Hi @Andy-MS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Andy Hanson). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

mhegazy
mhegazy reviewed May 16, 2016
View reviewed changes
src/harness/fourslash.ts
@@ -3044,6 +3085,18 @@ namespace FourSlashInterface {
this.state.verifyGetScriptLexicalStructureListContains(name, kind);
}

public navigationBarCount(count: number) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have these as verifyGetScriptLexicalStructureListCount.

@mhegazy
Copy link
Contributor

mhegazy commented May 16, 2016

so getScriptLexicalStructure was the old name for this API. i would rename these methods then to make sure they are easy to find.

@ghost ghost mentioned this pull request May 17, 2016
Merged
@ghost ghost force-pushed the navigation_bar_test branch from ee1a154 to cdc0008 Compare May 17, 2016 14:59
@mhegazy
Copy link
Contributor

mhegazy commented May 17, 2016

thanks!

@ghost ghost mentioned this pull request May 17, 2016
Closed
@mhegazy
Copy link
Contributor

mhegazy commented May 17, 2016

👍

@ghost ghost merged commit f93077f into master May 17, 2016
@ghost ghost deleted the navigation_bar_test branch May 17, 2016 17:44
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msftclas @mhegazy