Skip to content

ProductUpgradeTimer: remove unacceptable Environment.Exit() #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrickstolee merged 1 commit into from
May 28, 2020
Merged

ProductUpgradeTimer: remove unacceptable Environment.Exit() #1668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions GVFS/GVFS.Service/ProductUpgradeTimer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,22 +223,12 @@ private void TimerCallback(object unusedState)
this.DisplayUpgradeAvailableToast(newerVersion.ToString());
}
}
catch (Exception ex) when (
ex is IOException ||
ex is UnauthorizedAccessException ||
ex is NotSupportedException)
catch (Exception ex)
{
this.tracer.RelatedWarning(
CreateEventMetadata(ex),
"Exception encountered recording highest available version");
}
catch (Exception ex)
{
this.tracer.RelatedError(
CreateEventMetadata(ex),
"Unhanlded exception encountered recording highest available version");
Environment.Exit((int)ReturnCode.GenericError);
}
}
}

Expand Down