Fix mutable default list argument in config classes#384
Open
hobostay wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix mutable default list argument in config classes#384hobostay wants to merge 1 commit intomicrosoft:mainfrom
hobostay wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Replace mutable default `encoder_ratios=[8,5,5,4,2,2]` with `None` and initialize inside the method body. Python evaluates default arguments once at class definition time, so all instances share the same list object. Mutating it on one instance would silently corrupt all others. Also use `list(encoder_ratios)` when assigning `decoder_ratios` from `encoder_ratios` to avoid shared references between encoder and decoder. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoder_ratios=[8,5,5,4,2,2]inVibeVoiceAcousticTokenizerConfigandVibeVoiceSemanticTokenizerConfig.append(),.sort()) would silently corrupt all other instanceslist(encoder_ratios)when assigningdecoder_ratiosto avoid shared referencesDetails
Affected file:
vibevoice/modular/configuration_vibevoice.py(lines 55, 118)Changed
encoder_ratios: Optional[List[int]] = [8,5,5,4,2,2]toencoder_ratios: Optional[List[int]] = Nonewithif encoder_ratios is None: encoder_ratios = [8, 5, 5, 4, 2, 2]inside the method body. This is a well-known Python pitfall.Test plan
🤖 Generated with Claude Code