Skip to content

Use hard time limit on gradual memory reclaim #13154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use hard time limit on gradual memory reclaim #13154

wants to merge 1 commit into from

Conversation

Artoria2e5
Copy link

@Artoria2e5 Artoria2e5 commented Jun 20, 2025 •
edited
Loading

Summary of the Pull Request

This is a purely theoretical implementation of the fix proposed in #10675 (comment), under the assumption that an incomplete reclaim is causing things to throttle and hang. It is completely untested nor do I have any intention of testing it. For CLA purposes, I disclaim any rights that I may or may not have on this code.

PR Checklist

  • Closes: Link to issue Command hangs when autoMemoryReclaim=gradual with distro systemd enabled #10675
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

See the comment. This PR is only a tactic to draw attention. It has been made draft to make sure nobody merges it.

Uhhhh @OneBlue notice me please?

Validation Steps Performed

The vibes are right. There are probably three missing includes.

@Artoria2e5
Use hard time limit on gradual memory reclaim
4264977 
This is a purely theoretical implementation of the fix proposed in https://github.com/Artoria2e5, under the assumption that an incomplete reclaim is causing things to throttle and hang. It is completely untested nor do I have any intention of testing it. For CLA purposes, I disclaim any rights that I may or may not have on this code.
@Artoria2e5 Artoria2e5 requested a review from a team as a code owner June 20, 2025 11:22
@Artoria2e5 Artoria2e5 marked this pull request as draft June 20, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneBlue OneBlue Awaiting requested review from OneBlue OneBlue is a code owner automatically assigned from microsoft/wsl-maintainers

@benhillis benhillis Awaiting requested review from benhillis benhillis is a code owner automatically assigned from microsoft/wsl-maintainers

@craigloewen-msft craigloewen-msft Awaiting requested review from craigloewen-msft craigloewen-msft is a code owner automatically assigned from microsoft/wsl-maintainers

@justus-camp-microsoft justus-camp-microsoft Awaiting requested review from justus-camp-microsoft justus-camp-microsoft is a code owner automatically assigned from microsoft/wsl-maintainers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artoria2e5