Skip to content

feat: native Agent Skills support (v0.7.0)#58

Merged
danielmeppiel merged 3 commits into
mainfrom
feature/skills
Dec 19, 2025
Merged

feat: native Agent Skills support (v0.7.0)#58
danielmeppiel merged 3 commits into
mainfrom
feature/skills

Conversation

@danielmeppiel

Copy link
Copy Markdown
Collaborator
  • Install skills to .github/skills/ as primary target (agentskills.io standard)
  • Remove skill → agent transformation (skills ≠ agents)
  • Add explicit type field to apm.yml (instructions, skill, hybrid, prompts)
  • Validate and normalize skill names per agentskills.io spec
  • Copy skills to .claude/skills/ when .claude/ folder exists (compatibility)
  • Add PackageContentType enum and routing functions
  • Auto-create .github/ on install if neither .github/ nor .claude/ exists

- Install skills to .github/skills/ as primary target (agentskills.io standard)
- Remove skill → agent transformation (skills ≠ agents)
- Add explicit type field to apm.yml (instructions, skill, hybrid, prompts)
- Validate and normalize skill names per agentskills.io spec
- Copy skills to .claude/skills/ when .claude/ folder exists (compatibility)
- Add PackageContentType enum and routing functions
- Auto-create .github/ on install if neither .github/ nor .claude/ exists
Copilot AI review requested due to automatic review settings December 19, 2025 00:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements native Agent Skills support (v0.7.0) by adopting the agentskills.io standard. The key architectural changes are:

  • Skills now install to .github/skills/ as the primary location instead of .claude/skills/
  • Removal of the skill → agent transformation logic (skills and agents are now distinct primitives)
  • Introduction of explicit type field in apm.yml for package routing (instructions, skill, hybrid, prompts)
  • Skill name validation and normalization per agentskills.io spec
  • Compatibility copy to .claude/skills/ when that directory already exists

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
skill-strategy.md New architectural design document explaining the rationale for native skills support
skill-plan.md Detailed implementation plan with task breakdown and parallelization strategy
src/apm_cli/models/apm_package.py Added PackageContentType enum and type field parsing
tests/test_apm_package_models.py Comprehensive tests for PackageContentType and type field validation
src/apm_cli/integration/skill_integrator.py Major refactor: added validation, routing functions, direct skill copy, .claude/ compat
src/apm_cli/integration/agent_integrator.py Removed skill → agent transformation methods
tests/unit/integration/test_skill_integrator.py Extensive test coverage for new skill integration behavior
tests/unit/integration/test_agent_integrator.py Regression tests ensuring skills are not transformed to agents
tests/unit/integration/test_skill_transformer.py Updated with deprecation notes
src/apm_cli/cli.py Auto-create .github/, updated skill integration logic and cleanup
docs/*.md Updated documentation to reflect .github/skills/ as primary target
CHANGELOG.md Documents breaking changes and new features
pyproject.toml Version bump to 0.7.0

Comment thread src/apm_cli/integration/skill_integrator.py Outdated
Comment thread skill-plan.md Outdated
Comment thread src/apm_cli/cli.py Outdated
Per skill-strategy.md Decision 2 'Skills are explicit, not implicit':
- Updated _create_package_info helpers in all test classes to accept package_type
- TestCopySkillToTarget, TestNativeSkillIntegration, TestClaudeSkillsCompatibilityCopy
  now default to CLAUDE_SKILL for native skill tests
- TestSkillIntegrator tests that expect skill creation now pass HYBRID type
- Updated individual test method calls to set appropriate package types

All 143 skill integrator tests pass, 809 total unit tests pass.
- Simplify skill name validation regex (redundant alternation)
- Expand .github/ auto-creation comment with skill-strategy Decision 1 rationale
- Remove skill-plan.md and skill-strategy.md from repo (internal docs)
- Add internal planning docs to .gitignore
@danielmeppiel danielmeppiel merged commit 1155331 into main Dec 19, 2025
22 checks passed
@danielmeppiel danielmeppiel deleted the feature/skills branch February 27, 2026 09:41
sergio-sisternes-epam pushed a commit that referenced this pull request May 19, 2026
feat: native Agent Skills support (v0.7.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants