Fixing unintended formatting changes#5471
Merged
eerhardt merged 1 commit intomicrosoft:mainfrom Sep 4, 2024
Merged
Conversation
Member
Author
eerhardt
approved these changes
Aug 28, 2024
Member
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
Member
Author
|
/backport to release/8.2 |
Contributor
|
Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/10601707713 |
Open
3 tasks
|
@joperezr Is this ready to be merged? We're still experiencing the issue with 9.0 P4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
When making the workload changes, I ran the xml formatter on the SDK.targets file to format tabs/spaces and indentation correctly, but it looks like that made some formatting changes that introduced bugs like adding newlines to property values, which would then break conditions when doing string comparisons. Thanks a lot @eerhardt for debugging and finding this out. The changes in this PR revert all the formatting changes made in that PR, which means the net difference since 8.1 will be the addition of the new target.
Fixes #5436
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow