[release/9.3] Fix Blob Container Connection String Format Exception#9496
Merged
joperezr merged 6 commits intorelease/9.3from May 29, 2025
Merged
[release/9.3] Fix Blob Container Connection String Format Exception#9496joperezr merged 6 commits intorelease/9.3from
joperezr merged 6 commits intorelease/9.3from
Conversation
github-actions
bot
requested review from
eerhardt,
radical and
sebastienros
as code owners
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Member
|
The build failures don't look like they are caused by you: Is the branch currently broken? cc @joperezr |
eerhardt
reviewed
May 27, 2025
| var blobClient = blobContainer.GetBlobClient("testKey"); | ||
| var blobServiceClient = host.Services.GetRequiredService<BlobServiceClient>(); | ||
| var blobContainerClient = host.Services.GetRequiredService<BlobContainerClient>(); | ||
| await blobContainerClient.CreateIfNotExistsAsync(); // For Aspire 9.3 only |
Member
There was a problem hiding this comment.
Why is this necessary? Aspire should be creating the blob container, right?
Contributor
There was a problem hiding this comment.
Probably for the same reason we had to make this PR in 9.4 to fix some flaky tests. On 9.3 I would see failures without this line.
sebastienros
added
the
Servicing-consider
danmoseley
added
Servicing-approved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…72-to-release/9.3
Member
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
It was, but it is now fixed. I've rettriggered CI. |
Member
|
Looks like re-running doesn't fetch latest changes on target branch, I'll try closing and re-opening. Otherwise we can just rebase the branch. |
joperezr
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9472 to release/9.3
/cc @sebastienros
Customer Impact
When an Azure Storage blob container is deployed the connection is not compatible with the injected client, making it unusable.
Testing
Tested manually on Azure, added a functional test for the emulator and unit tests for the connection string builder. We don't have automated tests on Azure.
Risk
Low.
Regression?
Yes.