Fix potential crashes due to uninitialized variables in Gemini and ConversableAgent#7197
Open
RinZ27 wants to merge 1 commit intomicrosoft:fix_fsfrom
Open
Fix potential crashes due to uninitialized variables in Gemini and ConversableAgent#7197RinZ27 wants to merge 1 commit intomicrosoft:fix_fsfrom
RinZ27 wants to merge 1 commit intomicrosoft:fix_fsfrom
Conversation
…versableAgent I noticed several potential crash points where variables like 'ans' and 'arguments' could be used before initialization. - In gemini.py: Initialized 'ans' and token counters to handle edge cases where model names don't match hardcoded strings. Switched to an 'else' block for vision models to be more inclusive. - In conversable_agent.py: Initialized 'arguments' to None in both sync and async execute_function to prevent crashes when verbose=True and a function is not found.
crisprmart
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've identified and fixed several potential
UnboundLocalErrorcrashes in the Gemini client andConversableAgent.Context
gemini.py: The previous implementation of thecreatemethod had hardcoded checks for specific model names. If a vision model was used that didn't match the hardcoded strings, variables likeanswould remain uninitialized, leading to a crash. I've added default initializations and switched to a more inclusiveelseblock for vision models.conversable_agent.py: Inexecute_function(both sync and async), if a function was not found andverbose=Truewas set, the code would attempt to printargumentsbefore they were defined. I've initializedargumentstoNoneto prevent this.Types of changes
Checklist:
py_compile.