This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Remove concrete Conversations cast to enable DI of IConversations #6910
Closed
rido-min wants to merge 1 commit intomicrosoft:mainfrom
Closed
Remove concrete Conversations cast to enable DI of IConversations #6910rido-min wants to merge 1 commit intomicrosoft:mainfrom
rido-min wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…lementations (#15) * Initial plan * Add GetConversationMemberAsync to IConversations and remove casts to concrete Conversations class Co-authored-by: rido-min <[email protected]> * Fix documentation for GetConversationMemberAsync extension method Co-authored-by: rido-min <[email protected]> * Fix documentation for both GetConversationMemberAsync overloads Co-authored-by: rido-min <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: rido-min <[email protected]>
cleemullins
previously approved these changes
Dec 17, 2025
tracyboehrer
requested review from
MattB-msft
and removed request for
cleemullins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/botbuilder-dotnet/issues/6905
This pull request introduces a new method for retrieving a single conversation member by user ID and conversation ID, and updates existing code to use this new method instead of casting to a concrete type. This improves code clarity and maintainability by leveraging an interface extension method and updating interface definitions accordingly.
API and Interface Enhancements:
GetConversationMemberWithHttpMessagesAsyncto theIConversationsinterface, enabling retrieval of a single conversation member by user ID and conversation ID.MemoryConversationsfor test coverage.Extension Method Addition:
GetConversationMemberAsyncextension method forIConversations, which wraps the new interface method and returns aChannelAccount.Refactoring to Use the New Method:
SkillHandlerImpl.csandTeamsInfo.csto use the newGetConversationMemberAsyncextension method, removing the need for casting to the concreteConversationstype. [1] [2]