Skip to content

Use x64 MSVC to build x86 checkedc-clang compiler on Windows #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

mgrang
Copy link
Contributor

@mgrang mgrang commented Feb 23, 2021

This fixes the issue mentioned in checkedc/checkedc-clang#963

After this PR merges, we need to update the X86 Windows ADO jobs to set Test.Target.Arch to x64_x86.

For more details on arguments to vcvarsall.bat refer https://docs.microsoft.com/en-us/cpp/build/building-on-the-command-line?view=msvc-160

@mgrang mgrang changed the title Use x64 toolchain to build x86 compiler Use x64 MSVC to build x86 llvm/clang compiler on Windows Feb 23, 2021
@mgrang mgrang requested review from sulekhark and kkjeer February 23, 2021 19:28
Copy link
Contributor

@sulekhark sulekhark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mgrang mgrang changed the title Use x64 MSVC to build x86 llvm/clang compiler on Windows Use x64 MSVC to build x86 checkedc-clang compiler on Windows Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants