Fix compile errors related to free variables #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 14, 2020 17:10
dtarditi
approved these changes
Sep 16, 2020
| @@ -40,8 +40,8 @@ AllocVCG(void) | |||
| storageVCG = storageRootVCG; | |||
| storageLimitVCG = (channelNets + 1) * (channelNets + 1); | |||
| SCC = malloc<ulong>((channelNets + 1) * sizeof(ulong)); | |||
| perSCC = malloc<ulong>((channelNets + 1) * sizeof(ulong)); | |||
| removeVCG = malloc<_Ptr<constraintVCGType>>((channelNets + 1) * (channelNets + 1) * sizeof(constraintVCGType *)); | |||
| perSCC = malloc<ulong>((channelNets + 1) * sizeof(ulong)); | |||
There was a problem hiding this comment.
This looks like an unneeded white space change.
| @@ -293,7 +291,7 @@ SCCofVCG(_Array_ptr<nodeVCGType> VCG : count(channelNets + 1), | |||
| for (net = 1; net <= channelNets; net++) { | |||
| SCC[net] = VCG[net].netsBelowLabel; | |||
| if (SCC[net] > totalSCC) { | |||
| totalSCC = SCC[net]; | |||
| totalSCC = SCC[net]; | |||
There was a problem hiding this comment.
This looks like an unneeded white space change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compile errors that occurred in the Olden and Ptrdist benchmarks due to the changes in checkedc-clang/#903. The checkedc-clang PR detects free variables in declared and inferred bounds and emits a compiler error if free variables are found.
This PR changes some declared bounds and reorders some code so that no free variables are involved in declared and inferred bounds. In particular:
totalSCCarray pointer. in vcg.h usechannelNetsrather thantotalSCCin the declared bounds (totalSCCis allocated usingchannelNets).SCCofVCGmethod in vcg.c accepts an additional parameter for the length of theperSCCarray pointer. Many functions in vcg.c reference global variables in parameter bounds. Continuing to clean up these global references is a future work item Remove uses of global variables in parameter bounds #100.GetPhrasemethod in anagram.c references the parameterpchrather than the globalachPhrasein its declared bounds.