Ptrdist/anagram: Checked Strings #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtarditi this is waiting on a review. |
|
This is ready for review again, now includes unchecked blocks. |
|
Oh this may not build immediately, as hacks.h was in the other branch. Once merged it will. |
dtarditi
reviewed
Nov 16, 2017
| @@ -661,12 +661,11 @@ _Unchecked int Cdecl main(int cpchArgc, _Array_ptr<char*> ppchArgv : count(cpchA | |||
|
|
|||
| while (GetPhrase(&achPhrase[0], sizeof(achPhrase)) != NULL) { | |||
| if (isdigit(achPhrase[0])) { | |||
| cchMinLength = atoi((char*)achPhrase); | |||
| cchMinLength = atoi((_Nt_array_ptr<char>)achPhrase); | |||
There was a problem hiding this comment.
This cast should be wrapped in an unchecked block: casts from _Array_ptr to _Nt_array_ptr won't be allowed. The compiler work to add this checking is tracked by the existing work item checkedc/checkedc-clang#391.
dtarditi
approved these changes
Nov 16, 2017
lenary
commented
Nov 16, 2017
| void DumpWords(void) { | ||
| static int X; | ||
| int i; | ||
| X = (X+1) & 1023; | ||
| if (X != 0) return; | ||
| for (i = 0; i < cpwLast; i++) _Unchecked{ wprint((char*)apwSol[i]->pchWord); } | ||
| for (i = 0; i < cpwLast; i++) _Unchecked { wprint((_Nt_array_ptr<char>)apwSol[i]->pchWord); } |
There was a problem hiding this comment.
Then this won't be either
There was a problem hiding this comment.
Oh it has an unchecked block because we couldn't prove the bounds anyway.
There was a problem hiding this comment.
Yes, that's why I didn't mention it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on checkedc/checkedc#239
The good news is the only _Unchecked parts left are:
Inserted some dynamic bounds cast to cast from an array_ptr to a nt_array_ptr. This could be wrong, please make sure it's the right approach. The bounds in this file are all whacky, we should be using nt_array_ptr in far more places and i will revisit it after I've finished making everything else checked.