Skip to content

Add chromium path arguments#465

Merged
EzioLi01 merged 11 commits into
microsoft:masterfrom
RodBerw:chromium-path-support
Mar 11, 2024
Merged

Add chromium path arguments#465
EzioLi01 merged 11 commits into
microsoft:masterfrom
RodBerw:chromium-path-support

Conversation

@RodBerw
Copy link
Copy Markdown
Contributor

@RodBerw RodBerw commented Feb 7, 2024

No description provided.

Rodolfo Liberado (BEYONDSOFT CONSULTING INC) added 2 commits February 7, 2024 09:26
Comment thread bin/simulate Outdated
Comment thread src/browsers/browser.js Outdated
@EzioLi01
Copy link
Copy Markdown
Contributor

EzioLi01 commented Feb 9, 2024

@RodBerw Thanks for the contribution.
Generally I think chromium can only support windows here so far. You can add some logs:

  1. In win32 but not path argument set, will throw exception
  2. In other OSs and set path, only show log to notice that not support, but not stop whole process.

Comment thread bin/simulate Outdated
Comment thread bin/simulate Outdated
Comment thread bin/simulate Outdated
Comment thread src/simulate.js Outdated
Comment thread src/simulate.js Outdated
Comment thread src/simulate.js Outdated
@EzioLi01
Copy link
Copy Markdown
Contributor

EzioLi01 commented Mar 8, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/browsers/browser.js Outdated
@EzioLi01
Copy link
Copy Markdown
Contributor

EzioLi01 commented Mar 9, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@EzioLi01
Copy link
Copy Markdown
Contributor

LGTM, thanks for the contribution!

@EzioLi01 EzioLi01 merged commit d052b51 into microsoft:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants