Skip to content
This repository was archived by the owner on Jul 15, 2023. It is now read-only.

Remove ApiPort.VisualStudio.2015 #624

Merged
chlowell merged 5 commits into from
May 2, 2018
Merged

Remove ApiPort.VisualStudio.2015 #624

chlowell merged 5 commits into from
May 2, 2018

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented Apr 25, 2018 •
edited
Loading

This removes our Visual Studio 2015 extension.

twsouthwick
twsouthwick approved these changes Apr 27, 2018
View reviewed changes
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does this get rid of all the annoying binding redirect warnings in the build?

@chlowell
Copy link
Member Author

chlowell commented Apr 27, 2018

Sorry to report it doesn't. Resolving the binding conflicts by upgrading to newer dependencies introduces ~40 warnings from VS SDK analyzers, which I haven't worked through.

@conniey
Copy link
Member

conniey commented Apr 27, 2018

Sorry to report it doesn't. Resolving the binding conflicts by upgrading to newer dependencies introduces ~40 warnings from VS SDK analyzers, which I haven't worked through.

Maybe we shouldn't upgrade them. Ahaha.

@chlowell
Copy link
Member Author

chlowell commented Apr 27, 2018

I'm thinking the same thing but haven't determined exactly which dependencies we need. We can hold off merging this until that's done, this work isn't really complete if we ship assemblies we don't use.

@chlowell
Copy link
Member Author

chlowell commented May 2, 2018 •
edited
Loading

I found a usable version of the VS threading library which does not include the analyzers 🙈 and eliminates the binding warnings. Two birds, one hug.

@chlowell chlowell merged commit 9aed82f into microsoft:dev May 2, 2018
@chlowell chlowell deleted the remove-2015 branch May 2, 2018 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@twsouthwick twsouthwick twsouthwick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chlowell @conniey @twsouthwick