This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Added showExceptionApis argument to the ApiPort Client #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 8, 2020 12:26
…t is available to the rest of the api analysis.
…is included adding a place for exceptions to multiple models, specifically in the memberinfo and the analysisresponse models. Added a method in the analysis engine to find if a member throws an exception. Also added some helper methods for getting exceptions.
…ort is now able to take an offline catalog.bin and print out the exceptions that may be thrown in the JSON analysis response.
…an hold whatever we want, in this case exceptions, while still keeping compatability if no catalog is passed in. This means that ApiPort.Offline can run without needing a .bin file with exceptions. However, a new file will need to be made in order to get the Exceptions from.
…tch with the ApiCatalog
… dotnetcatalog file. Also connected up the retrieval of the additional data catalog into the catalog lookup so that the exceptions can be retrieved.
… but still throw other exceptions. This is because the missing file is somewhat expected at the current time when the program is run without the exceptions.bin file.
… the ApiException model for proper equality checking and a formatted string containing the exception data.
…so that the exception data is only passed back when requested.
…different from the memberinfo models. This means that less data will be duplicated in the json response and that what the exceptions and general missing api return will be different seperate objects.
…eference and clarity on what does what. Also cleaned up one or two small pieces of code.
…the offline and local backend run styles.
…r the specific method and platform.
…for release (checking for proper formatting and style).
Lxiamail
approved these changes
Jul 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added showExceptionApis argument to the ApiPort Client. This will allow for the addition of methods that throw exceptions in requests for ApiPort analysis. The changes made followed the same format as the other command line arguments with the option to use -x or --showExceptionApis to get exception throwing Apis included in the report.