This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dialog): make width responsive #2193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Dec 17, 2019
| }, | ||
| '@media (min-width: 1280px)': { | ||
| width: v.rootWidth, | ||
| }, |
There was a problem hiding this comment.
@codepretty can you please provide proper breakpoints? 🙏
There was a problem hiding this comment.
Trying to nail down the breakpoint logic with Design... Almost have it figured out.
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
mnajdova
reviewed
Feb 4, 2020
| rootWidthLarge: '50vw', | ||
| rootWidthLargeBreakpoint: '@media (min-width: 1280px)', | ||
| rootWidthMedium: '75vw', | ||
| rootWidthBreakpointMedium: '@media (min-width: 768px)', |
There was a problem hiding this comment.
Suggested change
| rootWidthBreakpointMedium: '@media (min-width: 768px)', | |
| rootWidthMediumBreakpoint: '@media (min-width: 768px)', |
mnajdova
reviewed
Feb 4, 2020
|
|
||
| rootWidth: '90vw', | ||
| rootWidthLarge: '50vw', | ||
| rootWidthLargeBreakpoint: '@media (min-width: 1280px)', |
There was a problem hiding this comment.
I am kind a leaning more towards allowing users to specify only the px value here, not the whole string, but I am not sure. We should make that decision now, as this is the first PR that is adding breakpoints
There was a problem hiding this comment.
I am not sure that we should limit user there as media queries support a lot of attributes:
https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries
mnajdova
reviewed
Feb 4, 2020
| @@ -16,6 +16,13 @@ export default { | |||
| gridTemplateColumns: '1fr auto', | |||
| boxShadow: v.boxShadow, | |||
| color: v.foregroundColor, | |||
|
|
|||
| [v.rootWidthBreakpointMedium]: { | |||
There was a problem hiding this comment.
Shouldn't we check whether it is defined first?
There was a problem hiding this comment.
It's required by typings. Why we need to have additional checks there?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2139.
This PR adds
mediaselectors forDialogto make it responsible: