Skip to content

Reset wantsHighFrameRateIdle on pan gesture end#2250

Merged
lukas-cap merged 1 commit intomainfrom
user/lucapkov/fixHighFrameRateIdleReset
Mar 13, 2026
Merged

Reset wantsHighFrameRateIdle on pan gesture end#2250
lukas-cap merged 1 commit intomainfrom
user/lucapkov/fixHighFrameRateIdleReset

Conversation

@lukas-cap
Copy link
Copy Markdown
Contributor

@lukas-cap lukas-cap commented Mar 12, 2026

When an in-flight spring animation is interrupted via completeAnimationsIfNeeded(), the completion block that resets wantsHighFrameRateIdle is never called. Reset the flag in pan .ended/.cancelled/.failed to ensure it doesn't remain enabled past the gesture lifecycle.

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

(a summary of the changes made, often organized by file)

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

When an in-flight spring animation is interrupted via completeAnimationsIfNeeded(),
the completion block that resets wantsHighFrameRateIdle is never called. Reset the
flag in .ended/.cancelled/.failed to ensure it doesn't remain enabled past the
gesture lifecycle.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lukas-cap lukas-cap requested a review from a team as a code owner March 12, 2026 22:35
@lukas-cap lukas-cap enabled auto-merge (squash) March 12, 2026 22:45
@lukas-cap lukas-cap merged commit 9ff78ab into main Mar 13, 2026
10 checks passed
@lukas-cap lukas-cap deleted the user/lucapkov/fixHighFrameRateIdleReset branch March 13, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants