[MessageBox] Fix the MessageBox usage in WASM projects #v3 #1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1062.westeurope.3.azurestaticapps.net |
vnbaaij
requested changes
Dec 4, 2023
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1062.westeurope.3.azurestaticapps.net |
…com-perso:microsoft/fluentui-blazor into users/dvoituron/fix-messagebox-wasm-trimmed
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1062.westeurope.3.azurestaticapps.net |
vnbaaij
approved these changes
Dec 5, 2023
vnbaaij
added a commit
that referenced
this pull request
Dec 14, 2023
* Avoid to remove MessageBox in WASM projects #v3 * Fix comment --------- Co-authored-by: Vincent Baaij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MessageBox] Fix the MessageBox usage in WASM projects
During the WASM DotNet Publication process, the unused classes are automatically removed from the final library. The Dialog razor file will be removed if no reference are set by your code. For example, if you call
var = await DialogService.ShowDialogAsync<SimpleDialog>(simplePerson, parameters);the SimpleDialog will be removed by the WASM Publication process. You can configure this behavior by setting the PublishTrimmed property in your project file or you can create a temporary instancevar temp1 = new SimpleDialog();to force the Publication process to keep this class in the final library.In this PR, this action has been taken for the MessageBox class, to solve #1057.
Another solution could be to use:
Examples:
Before
After
