Add FluentValidationMessage and Required #1079
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
dvoituron
left a comment
dvoituron
left a comment
There was a problem hiding this comment.
As I put it in the code, I think it's a problem to link FluentInputLabel to the component. For me, it's better to use a composition of components. Especially as the way of representing an Input Label may change from one component to another.
The FluentInputLabel could only use its Required property to display this asterisk or not.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
…nts accordingly. Add property to LibraryConfiguration to make required label adjustable
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
|
|
||
| <CascadingValue Value=@_internalListContext Name="ListContext" TValue="InternalListContext<TOption>" IsFixed=true> | ||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" /> | ||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" Required=@Required /> |
There was a problem hiding this comment.
To be coherent with other attributes, could you add double-quotes: Required="@Required"?
| @inherits FluentCalendarBase | ||
|
|
||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" /> | ||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" Required=@Required TValue="DateTime?" /> |
There was a problem hiding this comment.
To be coherent with other attributes, could you add double-quotes: Required="@required"?
| @inherits FluentCalendarBase | ||
|
|
||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" /> | ||
| <FluentInputLabel ForId="@Id" Label="@Label" AriaLabel="@AriaLabel" ChildContent="@LabelTemplate" Required=@Required TValue="DateTime?" /> |
There was a problem hiding this comment.
Left-over from previos Input paramer thing. Will remove
|
Some Unit test fail: |
…soft/fluentui-blazor into vnbaaij/validation-message
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1079.westeurope.3.azurestaticapps.net |
* Inital validation message work * Initial validation message and required indicator work * Fix, update and add Slider tests * Remove Input parameter from FluentInputLabel and change input components accordingly. Add property to LibraryConfiguration to make required label adjustable
Initial work to add FluentValidationMessage and a Reuired indicator after the label.
This does not yet contain the global flag we discussed. Fix #838 #1055