[DialogService] Add a fake instance of DialogEventArgs #280

[dvoituron]

[DialogService] Add a fake instance of DialogEventArgs #280

Add this line to prevent the Trimming process from deleting this class?

_ = new DialogEventArgs() { Id = "0", Reason = "Unknown" };

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1223.westeurope.3.azurestaticapps.net

[vnbaaij]

Should we not use a DynamicDependencyAttribute for this:
[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(DialogEventArgs))]

See recommendations under https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming?pivots=dotnet-8-0

[dvoituron]

Should we not use a DynamicDependencyAttribute for this: [DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(DialogEventArgs))]

See recommendations under https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming?pivots=dotnet-8-0

I don't think so, but maybe I'm wrong. In my opinion, this feature is useful when calling a method that uses reflection. It adds a warning at compile time to inform the developer. Here, we're not using reflection with this class. However, adding this tiny class to the lib should correct this problem.

[dvoituron]

@vnbaaij You're probably right, this code is probably cleaner. I'll update it

[DynamicDependency(DynamicallyAccessedMemberTypes.All, typeof(DialogEventArgs))]
public partial class DialogService : IDialogService
{
}

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1223.westeurope.3.azurestaticapps.net

[github-actions]

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1223.westeurope.3.azurestaticapps.net