Fix #1205 FluentButton submit does not work outside the EditForm #v3 #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1225.westeurope.3.azurestaticapps.net |
dvoituron
approved these changes
Dec 27, 2023
Make tests pass again
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1225.westeurope.3.azurestaticapps.net |
vnbaaij
added a commit
that referenced
this pull request
Dec 28, 2023
vnbaaij
added a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an error on the FAST side (microsoft/fluentui#31506), a FluentButton oouside of a form generates an error when trying to submit. The suggested workaround from the referenced issue is implementend with this PR in a colloacted script. The form as described in microsoft/fast#1205 can be submitted now with the FluentButton being outside of the form.
PR also includes IAsyncDisposable implementaiton for previous Slider PR