List related refactoring and maintenance #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- AutoComplete: remove virtual keyword - Make Option<> with Icon work for all types - Cleanup IssueTester
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1372.westeurope.3.azurestaticapps.net |
Move List examples into 1 folder
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1372.westeurope.3.azurestaticapps.net |
dvoituron
requested changes
Jan 23, 2024
dvoituron
requested changes
Jan 23, 2024
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1372.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-pebble-0dc79cb03-1372.westeurope.3.azurestaticapps.net |
dvoituron
approved these changes
Jan 23, 2024
vnbaaij
added a commit
that referenced
this pull request
Jan 23, 2024
* [DataGrid] - Add Loading and LoadingContent parameters * Additional height work * Process review comments * - Simplyfy option rendering - AutoComplete: remove virtual keyword - Make Option<> with Icon work for all types - Cleanup IssueTester * Fix compiler warnings/messages * Undo compiler warning fix because of side-effects Move List examples into 1 folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change components in such a way that it does not matter if the options come from an
IEnumerable<TOption>or from manually specifiedFluentOptions. We find the selected option with JS in the aria-activedescendant attribute and then callOnClickHandleron on the correspondingFluentOption<TOption>Simplify option rendering by using a single
RenderOptionsmethod. Move check if Items exist to this method. If no, just outpud ChildContent. If yes, render theFluentOptionsMake Option with Icon work for all types in
RenderOptions. In earlier code this only worked when T was a stringAutoComplete: remove virtual keyword
Cleanup IssueTester