Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

@MarvinKlein1508 MarvinKlein1508 commented Jun 20, 2024

Pull Request

📖 Description

This fixes the issue that the FluentDatePicker does not work, when the value of @bind is null. The issue comes from the fact that
(value ?? DateTime.MinValue).Date + Value?.TimeOfDay returns always null when Value is null

🎫 Issues

📑 Test Plan

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Collaborator

@dvoituron dvoituron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a UnitTest to validate this particular case?

@MarvinKlein1508
Copy link
Collaborator Author

@dvoituron added UNIT-Test

@vnbaaij vnbaaij changed the title Change OnSelectedDateAsync logic [DatePicker] Change OnSelectedDateAsync logic Jun 20, 2024
@vnbaaij vnbaaij enabled auto-merge (squash) June 20, 2024 11:30
@vnbaaij vnbaaij merged commit 804ebc0 into microsoft:dev Jun 20, 2024
@vnbaaij vnbaaij added this to the v4.8.2 milestone Jun 25, 2024
@MarvinKlein1508 MarvinKlein1508 deleted the fix-2197 branch June 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants