Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

Pull Request

📖 Description

this PR removes the fragment from the demo navigation for the /DateTime link.

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the fragment should be removed. It just needs to point to the default time picker example on that page.

@MarvinKlein1508
Copy link
Collaborator Author

@vnbaaij I removed it since all other components don't have one as well. It would be strange to start the page right in the middle since there is no nav item for FluentDatePicker

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jun 24, 2024

Yes, it is strange but even stranger to click on a link to time picker and land on a date picker segment 😀.

Time picker is an InputBase derived component. That is why it is shown in Form and input menu. DatePicker is not InputBase derived (yet?).

We need to address the underlying issue and probably just make separate pages.

@MarvinKlein1508
Copy link
Collaborator Author

Got it. Added the fragment. I didn't even know that you can find the FluentDatePicker under components instead.

@vnbaaij vnbaaij self-requested a review June 24, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants