[Docs] Add icon preview in API documentation #2284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
reviewed
Jun 27, 2024
Collaborator
dvoituron
left a comment
dvoituron
left a comment
There was a problem hiding this comment.
Can you add an screenshot to explain the result?
Contributor
Author
|
|
Collaborator
|
Won't this cause confusion with the other icons (i) for example? I'm afraid users will wonder why we put an "Information" symbol there. Maybe in a tooltip? |
Collaborator
|
Or show "Preview: {image}" and show the icon name in a tooltip? |
Collaborator
|
Also a good solution |
Contributor
Author
|
|
vnbaaij
requested changes
Jun 28, 2024
dvoituron
approved these changes
Jun 28, 2024
vnbaaij
changed the title
vnbaaij
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added preview icon on API documentation