Skip to content

Conversation

@oneolddev
Copy link
Contributor

Pull Request

📖 Description

API documentation did not always show nullable type for parameters or method return.

🎫 Issues

  • Only the underlying type shown even though it was declared nullable. It does not match the source code.

Before

image

After

image

👩‍💻 Reviewer Notes

Changes were made to the ToTypeNameString extensions instead of APIDocumentation. Only concern I have is that the original extensions were sourced from https://github.com/loxsmoke/DocXml.

📑 Test Plan

  • I manually checked many of the components.

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

@oneolddev oneolddev marked this pull request as ready for review October 4, 2024 05:16
@vnbaaij
Copy link
Collaborator

vnbaaij commented Oct 4, 2024

Changes were made to the ToTypeNameString extensions instead of APIDocumentation. Only concern I have is that the original extensions were sourced from https://github.com/loxsmoke/DocXml.

Hi Gary (@oneolddev). Why does that concern you? We used that as the base back then but have made significant changes along the way. We are not going back anytime to copying the original code again, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants