Skip to content

Conversation

@miguelhasse
Copy link
Contributor

Pull Request

πŸ“– Description

Implementation of an Odata IAsyncQueryExecutor.

πŸ“‘ Test Plan

I've created a test sample using TripPin sample OData service available here TripPin Service

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

@vnbaaij
Copy link
Collaborator

vnbaaij commented Nov 19, 2024

Hi,

Bit late to the party but can you change the project folder and name to Microsoft.FluentUI.AspNetCore.Components.DataGrid.ODataAdapter so we stay in line with the EF naming scheme. Also, I think adding .Client could be a bit misleading on what it is and does.
Oh, and you'd need to update the readme of course...

@vnbaaij vnbaaij changed the title Odata AsyncQueryExecutor [DataGrid] Add OData Adaptor package Nov 19, 2024
…ata.Client' to 'Microsoft.FluentUI.AspNetCore.Components.DataGrid.ODataAdapter'
@miguelhasse
Copy link
Contributor Author

@vnbaaij renaming done!

@vnbaaij vnbaaij merged commit 42877bf into microsoft:dev Nov 19, 2024
4 checks passed
@vnbaaij vnbaaij added this to the v4.11 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants