Skip to content

Conversation

@MarvinKlein1508
Copy link
Collaborator

Pull Request

📖 Description

When a FluentButton is being used as an anchor to trigger a FluentInputFile in combination with the property Loading then the registered event will be lost once the button renders again to display the loading style. This PR fixes this by reattaching the event when it's necessary.

🎫 Issues

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

Perhaps you might want to add a test-case for this. I sadly don't know how to do this but I will take a look on it when you add one to learn from it! 😀

@vnbaaij vnbaaij dismissed dvoituron’s stale review November 17, 2024 20:52

seems like a glitch. No need to hold merging back

@vnbaaij vnbaaij changed the title [FluentInputFile] Fix anchor to FluentInputFile not working [InputFile] Make it work icw a loading Button Nov 18, 2024
@vnbaaij vnbaaij merged commit d5ffd21 into microsoft:dev Nov 18, 2024
4 checks passed
@MarvinKlein1508 MarvinKlein1508 deleted the anchor-fluentinput-issue branch November 18, 2024 11:46
@vnbaaij vnbaaij added this to the v4.11 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants